-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a monotonous behaviour to 'slowly approach if jump to big' #12
Comments
I see what you mean. Would make sense as an alternative soft-takeover variant. The reason why I didn't implement this already is exactly because of the fact that a mapping then needs to memorize the previous x value (basically to calculate a relative increment from two subsequent absolute values). But in the new ReaLearn a mode is allowed to have state, so memorizing the previous x value is easy now. |
@jackmau This is actually a good first issue if you want to contribute because you don't even need to fully dive into ReaLearn in order to implement the basic logic. The Mode concept (including the jump logic) is implemented in a standalone crate named helgoboss-learn. It shouldn't be so hard to start there because this crate is very minimal, no REAPER, no FFI, no VST, no UI, very few dependencies, pretty straight-forward Rust. And it has lots of unit tests that illustrate how the structs are supposed to be used and which results are expected. You could get familiar with basic Rust development and then have a look at the code that handles jumps. The integration into ReaLearn in terms of UI/persistence can happen after that. |
@jackmau How is it going with Rust? :) Please let me know if you plan to work on this feature. If not, I might give it a try in some days. |
@helgoboss slowly, and painfully, but I have started the Rust Book, my C++ (and core programming skills) are quite _Rust_ed. The code is pretty self-explanatory, the build process less so :) bu tthank you for having updated the guide on the build process, I had'nt seen that but that should simplify my life a lot |
soft-take over is implemented now? |
I will give it a shot tomorrow. I want to combine it with the more generic "Make relative" option. |
it's better a virtual midi out device that will do this, no? |
Hi,
As much as I am fun of soft-takeover, I don't like the way it works in Realearn, I'd much prefer a situation in which target always follows the same direction of the source and converges to the source value. For example, suppose in 7-bit context, using the same notation as in realearn y = 63 and x=0. While increasing x, I'd expect y to increase as well, so that the two meet up at 127 (or before, I have no strong feelings on the topic). If I reverse the input direction while I am half way (suppose y = 95 and x = 63), I'd expect a mirror behaviour, so that x and y would meet at 0 or before.
In EEL2, I would expressed it as (I have not tested thoroughly, and it supposes the controller doesn't skip values, but it's just to get an idea of what I mean):
Unfortunately in the current EEL control transformation I don't have any way to access
x_old
, so I had to write my own EEL feedbacking realearn input, but I'd prefer a native implementationThe text was updated successfully, but these errors were encountered: