fmt #12
XuyangSongci.yml
on: push
Bitrot check
1m 32s
Book tests
1m 30s
Code coverage
21m 37s
Intra-doc links
1m 32s
Rustfmt
22s
Matrix: build
Matrix: test-32-bit
Matrix: test
Annotations
17 errors and 334 warnings
|
Book tests
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
|
|
Test on ubuntu-latest
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
|
|
Build target wasm32-unknown-unknown
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
|
|
Build target wasm32-wasi
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
|
|
Intra-doc links
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
|
|
Test on windows-latest
The operation was canceled.
|
|
Test on macOS-latest with beta features
The operation was canceled.
|
|
Test on windows-latest with beta features
The operation was canceled.
|
|
Test on windows-latest with nightly features
The operation was canceled.
|
|
Test on ubuntu-latest with nightly features
The operation was canceled.
|
|
Test on macOS-latest
The operation was canceled.
|
|
Test on i686-unknown-linux-gnu
Process completed with exit code 101.
|
|
Test on ubuntu-latest with beta features
The operation was canceled.
|
|
Test on macOS-latest with nightly features
The operation was canceled.
|
|
Test on i686-unknown-linux-gnu with nightly features
The operation was canceled.
|
|
Test on i686-unknown-linux-gnu with beta features
The operation was canceled.
|
|
Code coverage
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
an array of `Range` that is only one element:
halo2_gadgets/src/utilities.rs#L436
warning: an array of `Range` that is only one element
--> halo2_gadgets/src/utilities.rs:436:47
|
436 | decompose(pallas::Base::random(rng), &[0..255]);
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
= note: `-W clippy::single-range-in-vec-init` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::single_range_in_vec_init)]`
help: if you wanted a `Vec` that contains the entire range, try
|
436 | decompose(pallas::Base::random(rng), &(0..255).collect::<std::vec::Vec<usize>>());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: if you wanted an array of len 255, try
|
436 | decompose(pallas::Base::random(rng), &[0; 255]);
| ~~~~~~
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities.rs#L129
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities.rs:129:34
|
129 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities.rs#L120
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities.rs:120:34
|
120 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities.rs#L105
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities.rs:105:34
|
105 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities/lookup_range_check.rs#L52
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities/lookup_range_check.rs:52:38
|
52 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2_gadgets/src/utilities/double_and_add.rs#L126
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_gadgets/src/utilities/double_and_add.rs:126:19
|
126 | selector: &dyn Fn(&mut VirtualCells<C::Base>) -> Expression<C::Base>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2_gadgets/src/utilities/double_and_add.rs#L101
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_gadgets/src/utilities/double_and_add.rs:101:19
|
101 | selector: &dyn Fn(&mut VirtualCells<C::Base>) -> Expression<C::Base>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2_gadgets/src/utilities/double_and_add.rs#L79
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_gadgets/src/utilities/double_and_add.rs:79:28
|
79 | gradient_selector: &dyn Fn(&mut VirtualCells<C::Base>) -> Expression<C::Base>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2_gadgets/src/utilities/double_and_add.rs#L78
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_gadgets/src/utilities/double_and_add.rs:78:26
|
78 | secant_selector: &dyn Fn(&mut VirtualCells<C::Base>) -> Expression<C::Base>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-W clippy::type-complexity` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::type_complexity)]`
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/sinsemilla.rs#L659
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/sinsemilla.rs:659:48
|
659 | ... .chain(right.into_iter()),
| ^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `right`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:524:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/sinsemilla.rs#L658
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/sinsemilla.rs:658:48
|
658 | ... .chain(left.into_iter())
| ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `left`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:524:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-W clippy::useless-conversion` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2/src/transcript.rs#L95
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2/src/transcript.rs:95:10
|
95 | ) -> Result<RangeConstrained<C::Base, AssignedCell<C::Base, C::Base>>, Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-W clippy::type-complexity` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::type_complexity)]`
|
|
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true:
halo2/src/accumulator.rs#L43
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> halo2/src/accumulator.rs:43:1
|
43 | impl<C: CurveAffine> Into<Instance> for SplitAccumulator<C> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-W clippy::from-over-into` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::from_over_into)]`
help: replace the `Into` implementation with `From<accumulator::SplitAccumulator<C>>`
|
43 ~ impl<C: CurveAffine> From<SplitAccumulator<C>> for Instance {
44 ~ fn from(val: SplitAccumulator<C>) -> Self {
|
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
halo2/src/accumulator/verifier.rs#L531
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> halo2/src/accumulator/verifier.rs:531:28
|
531 | instances: &self.instances,
| ^^^^^^^^^^^^^^^ help: change this to: `self.instances`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
halo2/src/accumulator/verifier.rs#L471
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> halo2/src/accumulator/verifier.rs:471:28
|
471 | instances: &self.instances,
| ^^^^^^^^^^^^^^^ help: change this to: `self.instances`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-W clippy::needless-borrow` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`
|
|
method `squeeze_challenge` is never used:
halo2/src/transcript.rs#L92
warning: method `squeeze_challenge` is never used
--> halo2/src/transcript.rs:92:12
|
38 | / impl<C, TranscriptChip> Transcript<C, TranscriptChip>
39 | | where
40 | | C: CurveAffine,
41 | | TranscriptChip: TranscriptInstructions<C>,
| |______________________________________________- method in this implementation
...
92 | pub fn squeeze_challenge<const LENGTH: usize>(
| ^^^^^^^^^^^^^^^^^
|
|
struct `Verifier` is never constructed:
halo2/src/prover.rs#L17
warning: struct `Verifier` is never constructed
--> halo2/src/prover.rs:17:8
|
17 | struct Verifier<C, E, EndoscaleChip, TranscriptChip, TR>
| ^^^^^^^^
|
|
struct `AppCircuit` is never constructed:
halo2/src/prover.rs#L14
warning: struct `AppCircuit` is never constructed
--> halo2/src/prover.rs:14:8
|
14 | struct AppCircuit {}
| ^^^^^^^^^^
|
|
function `endoscale_chip` is never used:
halo2/src/accumulator/verifier.rs#L435
warning: function `endoscale_chip` is never used
--> halo2/src/accumulator/verifier.rs:435:8
|
435 | fn endoscale_chip<C: CurveAffine, E: EndoscaleInstructions<C>>() -> E
| ^^^^^^^^^^^^^^
|
|
function `transcript_chip` is never used:
halo2/src/accumulator/verifier.rs#L431
warning: function `transcript_chip` is never used
--> halo2/src/accumulator/verifier.rs:431:8
|
431 | fn transcript_chip<C: CurveAffine, T: TranscriptInstructions<C>>() -> T {
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
trait `accumulator::Accumulator<C>` is more private than the item `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof`:
halo2/src/accumulator/verifier.rs#L57
warning: trait `accumulator::Accumulator<C>` is more private than the item `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof`
--> halo2/src/accumulator/verifier.rs:57:5
|
57 | / pub fn verify_proof<A: Accumulator<C>>(
58 | | &mut self,
59 | | mut layouter: impl Layouter<C::Base>,
60 | | proof: Value<TR>,
61 | | instances: &[Instance],
62 | | is_base_case: Value<bool>,
63 | | ) -> Result<(Value<bool>, A::Output), Error> {
| |________________________________________________^ method `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof` is reachable at visibility `pub(crate)`
|
note: but trait `accumulator::Accumulator<C>` is only usable at visibility `pub(self)`
--> halo2/src/accumulator.rs:12:1
|
12 | trait Accumulator<C: CurveAffine> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
associated type `accumulator::Accumulator::Output` is more private than the item `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof`:
halo2/src/accumulator/verifier.rs#L57
warning: associated type `accumulator::Accumulator::Output` is more private than the item `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof`
--> halo2/src/accumulator/verifier.rs:57:5
|
57 | / pub fn verify_proof<A: Accumulator<C>>(
58 | | &mut self,
59 | | mut layouter: impl Layouter<C::Base>,
60 | | proof: Value<TR>,
61 | | instances: &[Instance],
62 | | is_base_case: Value<bool>,
63 | | ) -> Result<(Value<bool>, A::Output), Error> {
| |________________________________________________^ method `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof` is reachable at visibility `pub(crate)`
|
note: but associated type `accumulator::Accumulator::Output` is only usable at visibility `pub(self)`
--> halo2/src/accumulator.rs:16:5
|
16 | type Output: Into<Instance> + Copy;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(private_interfaces)]` on by default
|
|
trait `accumulator::Accumulator<C>` is more private than the item `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof`:
halo2/src/accumulator/verifier.rs#L57
warning: trait `accumulator::Accumulator<C>` is more private than the item `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof`
--> halo2/src/accumulator/verifier.rs:57:5
|
57 | / pub fn verify_proof<A: Accumulator<C>>(
58 | | &mut self,
59 | | mut layouter: impl Layouter<C::Base>,
60 | | proof: Value<TR>,
61 | | instances: &[Instance],
62 | | is_base_case: Value<bool>,
63 | | ) -> Result<(Value<bool>, A::Output), Error> {
| |________________________________________________^ method `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof` is reachable at visibility `pub(crate)`
|
note: but trait `accumulator::Accumulator<C>` is only usable at visibility `pub(self)`
--> halo2/src/accumulator.rs:12:1
|
12 | trait Accumulator<C: CurveAffine> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(private_bounds)]` on by default
|
|
unused variable: `is_base_case`:
halo2/src/accumulator.rs#L64
warning: unused variable: `is_base_case`
--> halo2/src/accumulator.rs:64:9
|
64 | is_base_case: Value<bool>,
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_is_base_case`
|
|
variable does not need to be mutable:
halo2/src/accumulator/verifier.rs#L593
warning: variable does not need to be mutable
--> halo2/src/accumulator/verifier.rs:593:13
|
593 | let mut proof = Blake2bRead::init(&proof[..]);
| ----^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
halo2/src/accumulator/verifier.rs#L571
warning: variable does not need to be mutable
--> halo2/src/accumulator/verifier.rs:571:13
|
571 | let mut proof = Blake2bRead::init(&proof[..]);
| ----^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused variable: `acc`:
halo2/src/accumulator/verifier.rs#L551
warning: unused variable: `acc`
--> halo2/src/accumulator/verifier.rs:551:21
|
551 | let (_, acc) = verifier.verify_proof::<SplitAccumulator<C>>(
| ^^^ help: if this is intentional, prefix it with an underscore: `_acc`
|
|
unused variable: `acc`:
halo2/src/accumulator/verifier.rs#L491
warning: unused variable: `acc`
--> halo2/src/accumulator/verifier.rs:491:21
|
491 | let (_, acc) = verifier.verify_proof::<SplitAccumulator<C>>(
| ^^^ help: if this is intentional, prefix it with an underscore: `_acc`
|
|
unused variable: `base`:
halo2/src/accumulator/verifier.rs#L425
warning: unused variable: `base`
--> halo2/src/accumulator/verifier.rs:425:13
|
425 | base: &<Self::FixedPoints as halo2_gadgets::ecc::FixedPoints<C>>::Base,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_base`
|
|
unused variable: `base_field_elem`:
halo2/src/accumulator/verifier.rs#L424
warning: unused variable: `base_field_elem`
--> halo2/src/accumulator/verifier.rs:424:13
|
424 | base_field_elem: Self::Var,
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_base_field_elem`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L423
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:423:13
|
423 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `base`:
halo2/src/accumulator/verifier.rs#L416
warning: unused variable: `base`
--> halo2/src/accumulator/verifier.rs:416:13
|
416 | base: &<Self::FixedPoints as halo2_gadgets::ecc::FixedPoints<C>>::ShortScalar,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_base`
|
|
unused variable: `scalar`:
halo2/src/accumulator/verifier.rs#L415
warning: unused variable: `scalar`
--> halo2/src/accumulator/verifier.rs:415:13
|
415 | scalar: &Self::ScalarFixedShort,
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_scalar`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L414
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:414:13
|
414 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `base`:
halo2/src/accumulator/verifier.rs#L407
warning: unused variable: `base`
--> halo2/src/accumulator/verifier.rs:407:13
|
407 | base: &<Self::FixedPoints as halo2_gadgets::ecc::FixedPoints<C>>::FullScalar,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_base`
|
|
unused variable: `scalar`:
halo2/src/accumulator/verifier.rs#L406
warning: unused variable: `scalar`
--> halo2/src/accumulator/verifier.rs:406:13
|
406 | scalar: &Self::ScalarFixed,
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_scalar`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L405
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:405:13
|
405 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `base`:
halo2/src/accumulator/verifier.rs#L398
warning: unused variable: `base`
--> halo2/src/accumulator/verifier.rs:398:13
|
398 | base: &Self::NonIdentityPoint,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_base`
|
|
unused variable: `scalar`:
halo2/src/accumulator/verifier.rs#L397
warning: unused variable: `scalar`
--> halo2/src/accumulator/verifier.rs:397:13
|
397 | scalar: &Self::ScalarVar,
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_scalar`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L396
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:396:13
|
396 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `b`:
halo2/src/accumulator/verifier.rs#L389
warning: unused variable: `b`
--> halo2/src/accumulator/verifier.rs:389:13
|
389 | b: &B,
| ^ help: if this is intentional, prefix it with an underscore: `_b`
|
|
unused variable: `a`:
halo2/src/accumulator/verifier.rs#L388
warning: unused variable: `a`
--> halo2/src/accumulator/verifier.rs:388:13
|
388 | a: &A,
| ^ help: if this is intentional, prefix it with an underscore: `_a`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L387
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:387:13
|
387 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `b`:
halo2/src/accumulator/verifier.rs#L380
warning: unused variable: `b`
--> halo2/src/accumulator/verifier.rs:380:13
|
380 | b: &Self::NonIdentityPoint,
| ^ help: if this is intentional, prefix it with an underscore: `_b`
|
|
unused variable: `a`:
halo2/src/accumulator/verifier.rs#L379
warning: unused variable: `a`
--> halo2/src/accumulator/verifier.rs:379:13
|
379 | a: &Self::NonIdentityPoint,
| ^ help: if this is intentional, prefix it with an underscore: `_a`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L378
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:378:13
|
378 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `a`:
halo2/src/accumulator/verifier.rs#L371
warning: unused variable: `a`
--> halo2/src/accumulator/verifier.rs:371:13
|
371 | a: &Self::NonIdentityPoint,
| ^ help: if this is intentional, prefix it with an underscore: `_a`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L370
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:370:13
|
370 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `point`:
halo2/src/accumulator/verifier.rs#L364
warning: unused variable: `point`
--> halo2/src/accumulator/verifier.rs:364:56
|
364 | fn extract_p<Point: Into<Self::Point> + Clone>(point: &Point) -> Self::X {
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_point`
|
|
unused variable: `magnitude_sign`:
halo2/src/accumulator/verifier.rs#L359
warning: unused variable: `magnitude_sign`
--> halo2/src/accumulator/verifier.rs:359:13
|
359 | magnitude_sign: (Self::Var, Self::Var),
| ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_magnitude_sign`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L358
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:358:13
|
358 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `value`:
halo2/src/accumulator/verifier.rs#L351
warning: unused variable: `value`
--> halo2/src/accumulator/verifier.rs:351:13
|
351 | value: Value<<C>::Scalar>,
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_value`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L350
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:350:13
|
350 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `value`:
halo2/src/accumulator/verifier.rs#L343
warning: unused variable: `value`
--> halo2/src/accumulator/verifier.rs:343:13
|
343 | value: Value<<C>::Scalar>,
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_value`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L342
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:342:13
|
342 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `value`:
halo2/src/accumulator/verifier.rs#L335
warning: unused variable: `value`
--> halo2/src/accumulator/verifier.rs:335:13
|
335 | value: Value<C>,
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_value`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L334
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:334:13
|
334 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `value`:
halo2/src/accumulator/verifier.rs#L327
warning: unused variable: `value`
--> halo2/src/accumulator/verifier.rs:327:13
|
327 | value: Value<C>,
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_value`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L326
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:326:13
|
326 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `b`:
halo2/src/accumulator/verifier.rs#L319
warning: unused variable: `b`
--> halo2/src/accumulator/verifier.rs:319:13
|
319 | b: &Self::Point,
| ^ help: if this is intentional, prefix it with an underscore: `_b`
|
|
unused variable: `a`:
halo2/src/accumulator/verifier.rs#L318
warning: unused variable: `a`
--> halo2/src/accumulator/verifier.rs:318:13
|
318 | a: &Self::Point,
| ^ help: if this is intentional, prefix it with an underscore: `_a`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L317
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:317:13
|
317 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `range`:
halo2/src/accumulator/verifier.rs#L283
warning: unused variable: `range`
--> halo2/src/accumulator/verifier.rs:283:13
|
283 | range: std::ops::Range<usize>,
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_range`
|
|
unused variable: `witnessed`:
halo2/src/accumulator/verifier.rs#L282
warning: unused variable: `witnessed`
--> halo2/src/accumulator/verifier.rs:282:13
|
282 | witnessed: &AssignedCell<F, F>,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_witnessed`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L281
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:281:13
|
281 | layouter: impl Layouter<F>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `num_bits`:
halo2/src/accumulator/verifier.rs#L273
warning: unused variable: `num_bits`
--> halo2/src/accumulator/verifier.rs:273:13
|
273 | num_bits: usize,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_num_bits`
|
|
unused variable: `witnessed`:
halo2/src/accumulator/verifier.rs#L272
warning: unused variable: `witnessed`
--> halo2/src/accumulator/verifier.rs:272:13
|
272 | witnessed: &AssignedCell<F, F>,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_witnessed`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L271
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:271:13
|
271 | layouter: impl Layouter<F>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L264
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:264:31
|
264 | fn squeeze(&mut self, layouter: impl Layouter<F>) -> Result<AssignedCell<F, F>, Error> {
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `value`:
halo2/src/accumulator/verifier.rs#L259
warning: unused variable: `value`
--> halo2/src/accumulator/verifier.rs:259:13
|
259 | value: AssignedCell<F, F>,
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_value`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L258
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:258:13
|
258 | layouter: impl Layouter<F>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `pub_input_rows`:
halo2/src/accumulator/verifier.rs#L234
warning: unused variable: `pub_input_rows`
--> halo2/src/accumulator/verifier.rs:234:13
|
234 | pub_input_rows: Vec<usize>,
| ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pub_input_rows`
|
|
unused variable: `bitstring`:
halo2/src/accumulator/verifier.rs#L233
warning: unused variable: `bitstring`
--> halo2/src/accumulator/verifier.rs:233:13
|
233 | bitstring: &Self::Bitstring,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bitstring`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L232
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:232:13
|
232 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `bitstring`:
halo2/src/accumulator/verifier.rs#L219
warning: unused variable: `bitstring`
--> halo2/src/accumulator/verifier.rs:219:13
|
219 | bitstring: &Self::Bitstring,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bitstring`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L218
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:218:13
|
218 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `bases`:
halo2/src/accumulator/verifier.rs#L211
warning: unused variable: `bases`
--> halo2/src/accumulator/verifier.rs:211:13
|
211 | bases: Vec<Self::NonIdentityPoint>,
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_bases`
|
|
unused variable: `bitstring`:
halo2/src/accumulator/verifier.rs#L210
warning: unused variable: `bitstring`
--> halo2/src/accumulator/verifier.rs:210:13
|
210 | bitstring: Vec<Self::Bitstring>,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bitstring`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L209
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:209:13
|
209 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `bases`:
halo2/src/accumulator/verifier.rs#L202
warning: unused variable: `bases`
--> halo2/src/accumulator/verifier.rs:202:13
|
202 | bases: Vec<Self::FixedBases>,
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_bases`
|
|
unused variable: `bitstring`:
halo2/src/accumulator/verifier.rs#L201
warning: unused variable: `bitstring`
--> halo2/src/accumulator/verifier.rs:201:13
|
201 | bitstring: Vec<Self::Bitstring>,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bitstring`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L200
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:200:13
|
200 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
|
unused variable: `for_base`:
halo2/src/accumulator/verifier.rs#L193
warning: unused variable: `for_base`
--> halo2/src/accumulator/verifier.rs:193:13
|
193 | for_base: bool,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_for_base`
|
|
unused variable: `bits`:
halo2/src/accumulator/verifier.rs#L192
warning: unused variable: `bits`
--> halo2/src/accumulator/verifier.rs:192:13
|
192 | bits: &[Value<bool>],
| ^^^^ help: if this is intentional, prefix it with an underscore: `_bits`
|
|
unused variable: `layouter`:
halo2/src/accumulator/verifier.rs#L191
warning: unused variable: `layouter`
--> halo2/src/accumulator/verifier.rs:191:13
|
191 | layouter: &mut impl Layouter<<C as CurveAffine>::Base>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_layouter`
|
= note: `#[warn(unused_variables)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2/src/transcript.rs#L95
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2/src/transcript.rs:95:10
|
95 | ) -> Result<RangeConstrained<C::Base, AssignedCell<C::Base, C::Base>>, Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-W clippy::type-complexity` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::type_complexity)]`
|
|
the borrowed expression implements the required traits:
halo2_gadgets/benches/poseidon.rs#L127
warning: the borrowed expression implements the required traits
--> halo2_gadgets/benches/poseidon.rs:127:25
|
127 | val.pow_vartime(&[5])
| ^^^^ help: change this to: `[5]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
|
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true:
halo2/src/accumulator.rs#L43
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> halo2/src/accumulator.rs:43:1
|
43 | impl<C: CurveAffine> Into<Instance> for SplitAccumulator<C> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-W clippy::from-over-into` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::from_over_into)]`
help: replace the `Into` implementation with `From<accumulator::SplitAccumulator<C>>`
|
43 ~ impl<C: CurveAffine> From<SplitAccumulator<C>> for Instance {
44 ~ fn from(val: SplitAccumulator<C>) -> Self {
|
|
|
associated items `new`, `common_point`, `common_scalar`, and `squeeze_challenge` are never used:
halo2/src/transcript.rs#L43
warning: associated items `new`, `common_point`, `common_scalar`, and `squeeze_challenge` are never used
--> halo2/src/transcript.rs:43:12
|
38 | / impl<C, TranscriptChip> Transcript<C, TranscriptChip>
39 | | where
40 | | C: CurveAffine,
41 | | TranscriptChip: TranscriptInstructions<C>,
| |______________________________________________- associated items in this implementation
42 | {
43 | pub fn new(transcript_chip: TranscriptChip) -> Self {
| ^^^
...
51 | pub fn common_point(
| ^^^^^^^^^^^^
...
80 | pub fn common_scalar(
| ^^^^^^^^^^^^^
...
92 | pub fn squeeze_challenge<const LENGTH: usize>(
| ^^^^^^^^^^^^^^^^^
|
|
struct `Transcript` is never constructed:
halo2/src/transcript.rs#L29
warning: struct `Transcript` is never constructed
--> halo2/src/transcript.rs:29:12
|
29 | pub struct Transcript<C, TranscriptChip>
| ^^^^^^^^^^
|
|
struct `Verifier` is never constructed:
halo2/src/prover.rs#L17
warning: struct `Verifier` is never constructed
--> halo2/src/prover.rs:17:8
|
17 | struct Verifier<C, E, EndoscaleChip, TranscriptChip, TR>
| ^^^^^^^^
|
|
struct `AppCircuit` is never constructed:
halo2/src/prover.rs#L14
warning: struct `AppCircuit` is never constructed
--> halo2/src/prover.rs:14:8
|
14 | struct AppCircuit {}
| ^^^^^^^^^^
|
|
associated items `new` and `verify_proof` are never used:
halo2/src/accumulator/verifier.rs#L42
warning: associated items `new` and `verify_proof` are never used
--> halo2/src/accumulator/verifier.rs:42:12
|
32 | / impl<
33 | | C: CurveAffine,
34 | | E: EncodedChallenge<C>,
35 | | EndoscaleChip: EndoscaleInstructions<C>,
... |
39 | | where
40 | | C::Base: PrimeFieldBits,
| |____________________________- associated items in this implementation
41 | {
42 | pub fn new(
| ^^^
...
57 | pub fn verify_proof<A: Accumulator<C>>(
| ^^^^^^^^^^^^
|
|
struct `Verifier` is never constructed:
halo2/src/accumulator/verifier.rs#L16
warning: struct `Verifier` is never constructed
--> halo2/src/accumulator/verifier.rs:16:12
|
16 | pub struct Verifier<C, E, EndoscaleChip, TranscriptChip, TR>
| ^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
trait `accumulator::Accumulator<C>` is more private than the item `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof`:
halo2/src/accumulator/verifier.rs#L57
warning: trait `accumulator::Accumulator<C>` is more private than the item `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof`
--> halo2/src/accumulator/verifier.rs:57:5
|
57 | / pub fn verify_proof<A: Accumulator<C>>(
58 | | &mut self,
59 | | mut layouter: impl Layouter<C::Base>,
60 | | proof: Value<TR>,
61 | | instances: &[Instance],
62 | | is_base_case: Value<bool>,
63 | | ) -> Result<(Value<bool>, A::Output), Error> {
| |________________________________________________^ method `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof` is reachable at visibility `pub(crate)`
|
note: but trait `accumulator::Accumulator<C>` is only usable at visibility `pub(self)`
--> halo2/src/accumulator.rs:12:1
|
12 | trait Accumulator<C: CurveAffine> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
associated type `accumulator::Accumulator::Output` is more private than the item `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof`:
halo2/src/accumulator/verifier.rs#L57
warning: associated type `accumulator::Accumulator::Output` is more private than the item `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof`
--> halo2/src/accumulator/verifier.rs:57:5
|
57 | / pub fn verify_proof<A: Accumulator<C>>(
58 | | &mut self,
59 | | mut layouter: impl Layouter<C::Base>,
60 | | proof: Value<TR>,
61 | | instances: &[Instance],
62 | | is_base_case: Value<bool>,
63 | | ) -> Result<(Value<bool>, A::Output), Error> {
| |________________________________________________^ method `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof` is reachable at visibility `pub(crate)`
|
note: but associated type `accumulator::Accumulator::Output` is only usable at visibility `pub(self)`
--> halo2/src/accumulator.rs:16:5
|
16 | type Output: Into<Instance> + Copy;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(private_interfaces)]` on by default
|
|
trait `accumulator::Accumulator<C>` is more private than the item `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof`:
halo2/src/accumulator/verifier.rs#L57
warning: trait `accumulator::Accumulator<C>` is more private than the item `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof`
--> halo2/src/accumulator/verifier.rs:57:5
|
57 | / pub fn verify_proof<A: Accumulator<C>>(
58 | | &mut self,
59 | | mut layouter: impl Layouter<C::Base>,
60 | | proof: Value<TR>,
61 | | instances: &[Instance],
62 | | is_base_case: Value<bool>,
63 | | ) -> Result<(Value<bool>, A::Output), Error> {
| |________________________________________________^ method `accumulator::verifier::Verifier::<C, E, EndoscaleChip, TranscriptChip, TR>::verify_proof` is reachable at visibility `pub(crate)`
|
note: but trait `accumulator::Accumulator<C>` is only usable at visibility `pub(self)`
--> halo2/src/accumulator.rs:12:1
|
12 | trait Accumulator<C: CurveAffine> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(private_bounds)]` on by default
|
|
unused variable: `is_base_case`:
halo2/src/accumulator.rs#L64
warning: unused variable: `is_base_case`
--> halo2/src/accumulator.rs:64:9
|
64 | is_base_case: Value<bool>,
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_is_base_case`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unused import: `plonk::Circuit`:
halo2/src/prover.rs#L5
warning: unused import: `plonk::Circuit`
--> halo2/src/prover.rs:5:5
|
5 | plonk::Circuit,
| ^^^^^^^^^^^^^^
|
|
unneeded unit expression:
halo2/src/accumulator/verifier.rs#L365
warning: unneeded unit expression
--> halo2/src/accumulator/verifier.rs:365:13
|
365 | ()
| ^^ help: remove the final `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `-W clippy::unused-unit` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unused_unit)]`
|
|
unused import: `Accumulator`:
halo2/src/accumulator/verifier.rs#L143
warning: unused import: `Accumulator`
--> halo2/src/accumulator/verifier.rs:143:23
|
143 | accumulator::{Accumulator, SplitAccumulator},
| ^^^^^^^^^^^
|
|
unused imports: `EpAffine`, `self`:
halo2/src/accumulator/verifier.rs#L128
warning: unused imports: `EpAffine`, `self`
--> halo2/src/accumulator/verifier.rs:128:13
|
128 | EpAffine, EqAffine,
| ^^^^^^^^
...
135 | self, Blake2bRead, Blake2bWrite, Challenge255, EncodedChallenge, TranscriptRead,
| ^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unused import: `plonk::Circuit`:
halo2/src/prover.rs#L5
warning: unused import: `plonk::Circuit`
--> halo2/src/prover.rs:5:5
|
5 | plonk::Circuit,
| ^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities.rs#L129
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities.rs:129:34
|
129 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities.rs#L120
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities.rs:120:34
|
120 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities.rs#L105
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities.rs:105:34
|
105 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities/lookup_range_check.rs#L52
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities/lookup_range_check.rs:52:38
|
52 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2_gadgets/src/utilities/double_and_add.rs#L126
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_gadgets/src/utilities/double_and_add.rs:126:19
|
126 | selector: &dyn Fn(&mut VirtualCells<C::Base>) -> Expression<C::Base>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2_gadgets/src/utilities/double_and_add.rs#L101
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_gadgets/src/utilities/double_and_add.rs:101:19
|
101 | selector: &dyn Fn(&mut VirtualCells<C::Base>) -> Expression<C::Base>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2_gadgets/src/utilities/double_and_add.rs#L79
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_gadgets/src/utilities/double_and_add.rs:79:28
|
79 | gradient_selector: &dyn Fn(&mut VirtualCells<C::Base>) -> Expression<C::Base>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2_gadgets/src/utilities/double_and_add.rs#L78
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_gadgets/src/utilities/double_and_add.rs:78:26
|
78 | secant_selector: &dyn Fn(&mut VirtualCells<C::Base>) -> Expression<C::Base>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-W clippy::type-complexity` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::type_complexity)]`
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon.rs#L206
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon.rs:206:33
|
206 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon.rs#L159
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon.rs:159:33
|
159 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon/primitives.rs#L378
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon/primitives.rs:378:33
|
378 | _domain: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon/primitives.rs#L272
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon/primitives.rs:272:33
|
272 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon/primitives.rs#L235
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon/primitives.rs:235:33
|
235 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon/primitives.rs#L221
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon/primitives.rs:221:33
|
221 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs#L103
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs:103:29
|
103 | val.pow_vartime(&[5])
| ^^^^ help: change this to: `[5]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs#L87
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs:87:38
|
87 | P128Pow5T5Gen(PhantomData::default())
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs#L51
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs:51:25
|
51 | val.pow_vartime(&[5])
| ^^^^ help: change this to: `[5]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
accessing first element with `slice.get(0)`:
halo2_proofs/src/helpers.rs#L86
warning: accessing first element with `slice.get(0)`
--> halo2_proofs/src/helpers.rs:86:40
|
86 | 4 + slice.len() * (4 + field_len * slice.get(0).map(|poly| poly.len()).unwrap_or(0))
| ^^^^^^^^^^^^ help: try: `slice.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_proofs/src/dev.rs#L1066
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_proofs/src/dev.rs:1066:30
|
1066 | ... .fold(Ok(()), |acc, res| acc.and(res))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold((), |acc, res| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `-W clippy::manual-try-fold` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs#L25
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs:25:25
|
25 | val.pow_vartime(&[5])
| ^^^^ help: change this to: `[5]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs#L88
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:88:38
|
88 | P128Pow5T3Gen(PhantomData::default())
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_proofs/src/dev/cost.rs#L414
warning: use of `default` to create a unit struct
--> halo2_proofs/src/dev/cost.rs:414:33
|
414 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_proofs/src/dev/cost.rs#L371
warning: use of `default` to create a unit struct
--> halo2_proofs/src/dev/cost.rs:371:33
|
371 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_proofs/src/dev/cost.rs#L328
warning: use of `default` to create a unit struct
--> halo2_proofs/src/dev/cost.rs:328:33
|
328 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/poly.rs#L175
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/poly.rs:175:22
|
175 | .zip(inv_denoms.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/poly.rs#L160
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/poly.rs:160:14
|
160 | .zip(assigned_denominators.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon/primitives/grain.rs#L72
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon/primitives/grain.rs:72:32
|
72 | _field: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/poly/multiopen/prover.rs#L105
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/poly/multiopen/prover.rs:105:58
|
105 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold(
| ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
use of `default` to create a unit struct:
halo2_proofs/src/poly/evaluator.rs#L124
warning: use of `default` to create a unit struct
--> halo2_proofs/src/poly/evaluator.rs:124:36
|
124 | _evaluator: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_proofs/src/poly/evaluator.rs#L78
warning: use of `default` to create a unit struct
--> halo2_proofs/src/poly/evaluator.rs:78:36
|
78 | _evaluator: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L559
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:559:20
|
559 | let xn = x.pow(&[8, 0, 0, 0]);
| ^^^^^^^^^^^^^ help: change this to: `[8, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L549
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:549:38
|
549 | points.push(domain.omega.pow(&[i, 0, 0, 0]));
| ^^^^^^^^^^^^^ help: change this to: `[i, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L510
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:510:77
|
510 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha);
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L470
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:470:73
|
470 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha);
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L444
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:444:62
|
444 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect();
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_gadgets/src/poseidon/pow5.rs#L256
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_gadgets/src/poseidon/pow5.rs:256:58
|
256 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| {
| __________________________________________________________^
257 | | res.and_then(|state| {
258 | | state.full_round(
259 | | &mut region,
... |
264 | | })
265 | | })?;
| |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_gadgets/src/poseidon/pow5.rs#L245
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_gadgets/src/poseidon/pow5.rs:245:61
|
245 | let state = (0..config.half_partial_rounds).fold(Ok(state), |res, r| {
| _____________________________________________________________^
246 | | res.and_then(|state| {
247 | | state.partial_round(
248 | | &mut region,
... |
253 | | })
254 | | })?;
| |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_gadgets/src/poseidon/pow5.rs#L241
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_gadgets/src/poseidon/pow5.rs:241:58
|
241 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| {
| __________________________________________________________^
242 | | res.and_then(|state| state.full_round(&mut region, config, r, r))
243 | | })?;
| |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `-W clippy::manual-try-fold` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`
|
|
accessing first element with `self
.selectors.get(0)`:
halo2_proofs/src/plonk.rs#L137
warning: accessing first element with `self
.selectors.get(0)`
--> halo2_proofs/src/plonk.rs:137:20
|
137 | * (self
| ____________________^
138 | | .selectors
139 | | .get(0)
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `-W clippy::get-first` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::get_first)]`
help: try
|
137 ~ * (self
138 + .selectors.first()
|
|
|
useless conversion to the same type: `std::slice::ChunksMut<'_, bool>`:
halo2_proofs/src/plonk.rs#L100
warning: useless conversion to the same type: `std::slice::ChunksMut<'_, bool>`
--> halo2_proofs/src/plonk.rs:100:37
|
100 | for (bits, byte) in selector.chunks_mut(8).into_iter().zip(selector_bytes) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `selector.chunks_mut(8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/verifier.rs#L319
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/verifier.rs:319:25
|
319 | / lookups
320 | | .iter()
321 | | .flat_map(move |p| p.queries(vk, x))
322 | | .into_iter(),
| |________________________________________^
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:524:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing the `.into_iter()`
|
319 ~ lookups
320 + .iter()
321 ~ .flat_map(move |p| p.queries(vk, x)),
|
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/verifier.rs#L259
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/verifier.rs:259:25
|
259 | / lookups
260 | | .iter()
261 | | .zip(vk.cs.lookups.iter())
262 | | .flat_map(move |(p, argument)| {
... |
275 | | })
276 | | .into_iter(),
| |________________________________________^
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:524:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing the `.into_iter()`
|
259 ~ lookups
260 + .iter()
261 + .zip(vk.cs.lookups.iter())
262 + .flat_map(move |(p, argument)| {
263 + p.expressions(
264 + l_0,
265 + l_last,
266 + l_blind,
267 + argument,
268 + theta,
269 + beta,
270 + gamma,
271 + advice_evals,
272 + fixed_evals,
273 + instance_evals,
274 + )
275 ~ }),
|
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/verifier.rs#L206
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/verifier.rs:206:24
|
206 | let xn = x.pow(&[params.n, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L707
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:707:24
|
707 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:524:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/prover.rs#L599
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/prover.rs:599:20
|
599 | let xn = x.pow(&[params.n, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L581
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:581:28
|
581 | .chain(permutation_expressions.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:524:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L547
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:547:14
|
547 | .zip(lookup_expressions.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookup_expressions`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L546
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:546:14
|
546 | .zip(permutation_expressions.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L412
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:412:42
|
412 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L407
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:407:37
|
407 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L390
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:390:68
|
390 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0]));
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/circuit.rs#L1261
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/circuit.rs:1261:22
|
1261 | .zip(degrees.into_iter())
| ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-W clippy::useless-conversion` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L220
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:220:45
|
220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L217
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:217:42
|
217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L200
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:200:53
|
200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L72
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:72:53
|
72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L65
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:65:38
|
65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L52
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:52:57
|
52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
|
field `strict` is never read:
halo2_gadgets/src/utilities/decompose_running_sum.rs#L39
warning: field `strict` is never read
--> halo2_gadgets/src/utilities/decompose_running_sum.rs:39:5
|
36 | pub struct RunningSum<F: PrimeFieldBits, const WINDOW_NUM_BITS: usize> {
| ---------- field in this struct
...
39 | strict: bool,
| ^^^^^^
|
= note: `RunningSum` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
|
|
associated function `new` is never used:
halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs#L86
warning: associated function `new` is never used
--> halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs:86:16
|
85 | impl<F: Field, const SECURE_MDS: usize> P128Pow5T5Gen<F, SECURE_MDS> {
| -------------------------------------------------------------------- associated function in this implementation
86 | pub fn new() -> Self {
| ^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
variable does not need to be mutable:
halo2_gadgets/src/utilities/bitstring.rs#L60
warning: variable does not need to be mutable
--> halo2_gadgets/src/utilities/bitstring.rs:60:9
|
60 | mut layouter: impl Layouter<F>,
| ----^^^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
halo2_gadgets/src/utilities/bitstring.rs#L51
warning: variable does not need to be mutable
--> halo2_gadgets/src/utilities/bitstring.rs:51:9
|
51 | mut layouter: impl Layouter<F>,
| ----^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
method `commitments` is never used:
halo2_proofs/src/plonk/permutation.rs#L85
warning: method `commitments` is never used
--> halo2_proofs/src/plonk/permutation.rs:85:12
|
83 | impl<C: CurveAffine> VerifyingKey<C> {
| ------------------------------------ method in this implementation
84 | /// Returns commitments of sigma polynomials
85 | pub fn commitments(&self) -> &Vec<C> {
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon.rs#L206
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon.rs:206:33
|
206 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon.rs#L159
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon.rs:159:33
|
159 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon/primitives.rs#L378
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon/primitives.rs:378:33
|
378 | _domain: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon/primitives.rs#L272
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon/primitives.rs:272:33
|
272 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon/primitives.rs#L235
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon/primitives.rs:235:33
|
235 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon/primitives.rs#L221
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon/primitives.rs:221:33
|
221 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs#L51
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs:51:25
|
51 | val.pow_vartime(&[5])
| ^^^^ help: change this to: `[5]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs#L25
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs:25:25
|
25 | val.pow_vartime(&[5])
| ^^^^ help: change this to: `[5]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon/primitives/grain.rs#L72
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon/primitives/grain.rs:72:32
|
72 | _field: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L510
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:510:77
|
510 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha);
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L470
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:470:73
|
470 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha);
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L444
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:444:62
|
444 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect();
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_gadgets/src/poseidon/pow5.rs#L256
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_gadgets/src/poseidon/pow5.rs:256:58
|
256 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| {
| __________________________________________________________^
257 | | res.and_then(|state| {
258 | | state.full_round(
259 | | &mut region,
... |
264 | | })
265 | | })?;
| |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_gadgets/src/poseidon/pow5.rs#L245
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_gadgets/src/poseidon/pow5.rs:245:61
|
245 | let state = (0..config.half_partial_rounds).fold(Ok(state), |res, r| {
| _____________________________________________________________^
246 | | res.and_then(|state| {
247 | | state.partial_round(
248 | | &mut region,
... |
253 | | })
254 | | })?;
| |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_gadgets/src/poseidon/pow5.rs#L241
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_gadgets/src/poseidon/pow5.rs:241:58
|
241 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| {
| __________________________________________________________^
242 | | res.and_then(|state| state.full_round(&mut region, config, r, r))
243 | | })?;
| |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `-W clippy::manual-try-fold` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L412
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:412:42
|
412 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L407
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:407:37
|
407 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L390
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:390:68
|
390 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0]));
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
use of deprecated associated function `std::array::IntoIter::<T, N>::new`: use `IntoIterator::into_iter` instead:
halo2_gadgets/src/endoscale/chip/alg_1.rs#L216
warning: use of deprecated associated function `std::array::IntoIter::<T, N>::new`: use `IntoIterator::into_iter` instead
--> halo2_gadgets/src/endoscale/chip/alg_1.rs:216:39
|
216 | std::array::IntoIter::new([
| ^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L220
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:220:45
|
220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L217
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:217:42
|
217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L200
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:200:53
|
200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L72
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:72:53
|
72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L65
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:65:38
|
65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L52
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:52:57
|
52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
|
field `strict` is never read:
halo2_gadgets/src/utilities/decompose_running_sum.rs#L39
warning: field `strict` is never read
--> halo2_gadgets/src/utilities/decompose_running_sum.rs:39:5
|
36 | pub struct RunningSum<F: PrimeFieldBits, const WINDOW_NUM_BITS: usize> {
| ---------- field in this struct
...
39 | strict: bool,
| ^^^^^^
|
= note: `RunningSum` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
|
|
field `table` is never read:
halo2_gadgets/src/endoscale/chip/alg_2.rs#L111
warning: field `table` is never read
--> halo2_gadgets/src/endoscale/chip/alg_2.rs:111:16
|
88 | pub(super) struct Alg2Config<C: CurveAffine, const K: usize, const MAX_BITSTRING_LENGTH: usize>
| ---------- field in this struct
...
111 | pub(super) table: TableConfig<C::Base, K>,
| ^^^^^
|
= note: `Alg2Config` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
variable does not need to be mutable:
halo2_gadgets/src/utilities/bitstring.rs#L60
warning: variable does not need to be mutable
--> halo2_gadgets/src/utilities/bitstring.rs:60:9
|
60 | mut layouter: impl Layouter<F>,
| ----^^^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
halo2_gadgets/src/utilities/bitstring.rs#L51
warning: variable does not need to be mutable
--> halo2_gadgets/src/utilities/bitstring.rs:51:9
|
51 | mut layouter: impl Layouter<F>,
| ----^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused imports: `ConstantLength`, `Hash`:
halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs#L77
warning: unused imports: `ConstantLength`, `Hash`
--> halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs:77:38
|
77 | generate_constants, permute, ConstantLength, Hash, Mds, Spec,
| ^^^^^^^^^^^^^^ ^^^^
|
|
unused import: `PrimeField`:
halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs#L69
warning: unused import: `PrimeField`
--> halo2_gadgets/src/poseidon/primitives/p128pow5t5.rs:69:39
|
69 | use ff::{Field, FromUniformBytes, PrimeField};
| ^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L109
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:109:13
|
109 | /// Selector assignments used for optimization pass
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
110 | selectors: vec![vec![false; n]; num_selectors],
| ---------------------------------------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
|
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L107
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:107:13
|
107 | /// Pairs of cells between which we have equality constraints.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
108 | equality: vec![],
| ---------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
|
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L105
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:105:13
|
105 | /// Any cells assigned outside of a region.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
106 | loose_cells: vec![],
| ------------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
= note: `#[warn(unused_doc_comments)]` on by default
|
|
unused imports: `ParallelIterator`, `Scope`:
halo2_proofs/src/multicore.rs#L15
warning: unused imports: `ParallelIterator`, `Scope`
--> halo2_proofs/src/multicore.rs:15:34
|
15 | iter::{IntoParallelIterator, ParallelIterator},
| ^^^^^^^^^^^^^^^^
16 | join, scope, Scope,
| ^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unused import: `pallas`:
halo2_proofs/examples/serialization.rs#L16
warning: unused import: `pallas`
--> halo2_proofs/examples/serialization.rs:16:20
|
16 | use pasta_curves::{pallas, EqAffine, Fp};
| ^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
use of deprecated associated function `std::array::IntoIter::<T, N>::new`: use `IntoIterator::into_iter` instead:
halo2_gadgets/src/endoscale/chip/alg_1.rs#L216
warning: use of deprecated associated function `std::array::IntoIter::<T, N>::new`: use `IntoIterator::into_iter` instead
--> halo2_gadgets/src/endoscale/chip/alg_1.rs:216:39
|
216 | std::array::IntoIter::new([
| ^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
accessing first element with `slice.get(0)`:
halo2_proofs/src/helpers.rs#L86
warning: accessing first element with `slice.get(0)`
--> halo2_proofs/src/helpers.rs:86:40
|
86 | 4 + slice.len() * (4 + field_len * slice.get(0).map(|poly| poly.len()).unwrap_or(0))
| ^^^^^^^^^^^^ help: try: `slice.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
|
|
use of `default` to create a unit struct:
halo2_proofs/src/dev/cost.rs#L414
warning: use of `default` to create a unit struct
--> halo2_proofs/src/dev/cost.rs:414:33
|
414 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_proofs/src/dev/cost.rs#L371
warning: use of `default` to create a unit struct
--> halo2_proofs/src/dev/cost.rs:371:33
|
371 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_proofs/src/dev/cost.rs#L328
warning: use of `default` to create a unit struct
--> halo2_proofs/src/dev/cost.rs:328:33
|
328 | _marker: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/poly.rs#L175
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/poly.rs:175:22
|
175 | .zip(inv_denoms.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/poly.rs#L160
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/poly.rs:160:14
|
160 | .zip(assigned_denominators.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/poly/multiopen/prover.rs#L105
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/poly/multiopen/prover.rs:105:58
|
105 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold(
| ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
use of `default` to create a unit struct:
halo2_proofs/src/poly/evaluator.rs#L124
warning: use of `default` to create a unit struct
--> halo2_proofs/src/poly/evaluator.rs:124:36
|
124 | _evaluator: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_proofs/src/poly/evaluator.rs#L78
warning: use of `default` to create a unit struct
--> halo2_proofs/src/poly/evaluator.rs:78:36
|
78 | _evaluator: PhantomData::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
|
|
accessing first element with `self
.selectors.get(0)`:
halo2_proofs/src/plonk.rs#L137
warning: accessing first element with `self
.selectors.get(0)`
--> halo2_proofs/src/plonk.rs:137:20
|
137 | * (self
| ____________________^
138 | | .selectors
139 | | .get(0)
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `-W clippy::get-first` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::get_first)]`
help: try
|
137 ~ * (self
138 + .selectors.first()
|
|
|
useless conversion to the same type: `std::slice::ChunksMut<'_, bool>`:
halo2_proofs/src/plonk.rs#L100
warning: useless conversion to the same type: `std::slice::ChunksMut<'_, bool>`
--> halo2_proofs/src/plonk.rs:100:37
|
100 | for (bits, byte) in selector.chunks_mut(8).into_iter().zip(selector_bytes) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `selector.chunks_mut(8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/verifier.rs#L319
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/verifier.rs:319:25
|
319 | / lookups
320 | | .iter()
321 | | .flat_map(move |p| p.queries(vk, x))
322 | | .into_iter(),
| |________________________________________^
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:524:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing the `.into_iter()`
|
319 ~ lookups
320 + .iter()
321 ~ .flat_map(move |p| p.queries(vk, x)),
|
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/verifier.rs#L259
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/verifier.rs:259:25
|
259 | / lookups
260 | | .iter()
261 | | .zip(vk.cs.lookups.iter())
262 | | .flat_map(move |(p, argument)| {
... |
275 | | })
276 | | .into_iter(),
| |________________________________________^
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:524:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing the `.into_iter()`
|
259 ~ lookups
260 + .iter()
261 + .zip(vk.cs.lookups.iter())
262 + .flat_map(move |(p, argument)| {
263 + p.expressions(
264 + l_0,
265 + l_last,
266 + l_blind,
267 + argument,
268 + theta,
269 + beta,
270 + gamma,
271 + advice_evals,
272 + fixed_evals,
273 + instance_evals,
274 + )
275 ~ }),
|
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/verifier.rs#L206
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/verifier.rs:206:24
|
206 | let xn = x.pow(&[params.n, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L707
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:707:24
|
707 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:524:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/prover.rs#L599
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/prover.rs:599:20
|
599 | let xn = x.pow(&[params.n, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L581
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:581:28
|
581 | .chain(permutation_expressions.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:524:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L547
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:547:14
|
547 | .zip(lookup_expressions.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookup_expressions`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L546
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:546:14
|
546 | .zip(permutation_expressions.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `permutation_expressions`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/circuit.rs#L1261
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/circuit.rs:1261:22
|
1261 | .zip(degrees.into_iter())
| ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/0e09125c6c3c2fd70d7de961bcf0e51575235fad/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-W clippy::useless-conversion` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`
|
|
method `commitments` is never used:
halo2_proofs/src/plonk/permutation.rs#L85
warning: method `commitments` is never used
--> halo2_proofs/src/plonk/permutation.rs:85:12
|
83 | impl<C: CurveAffine> VerifyingKey<C> {
| ------------------------------------ method in this implementation
84 | /// Returns commitments of sigma polynomials
85 | pub fn commitments(&self) -> &Vec<C> {
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L109
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:109:13
|
109 | /// Selector assignments used for optimization pass
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
110 | selectors: vec![vec![false; n]; num_selectors],
| ---------------------------------------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
|
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L107
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:107:13
|
107 | /// Pairs of cells between which we have equality constraints.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
108 | equality: vec![],
| ---------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
|
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L105
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:105:13
|
105 | /// Any cells assigned outside of a region.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
106 | loose_cells: vec![],
| ------------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
= note: `#[warn(unused_doc_comments)]` on by default
|
|
unused imports: `ParallelIterator`, `Scope`:
halo2_proofs/src/multicore.rs#L15
warning: unused imports: `ParallelIterator`, `Scope`
--> halo2_proofs/src/multicore.rs:15:34
|
15 | iter::{IntoParallelIterator, ParallelIterator},
| ^^^^^^^^^^^^^^^^
16 | join, scope, Scope,
| ^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
Book tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Book tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Book tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Book tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Book tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build target wasm32-unknown-unknown
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Build target wasm32-wasi
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build target wasm32-wasi
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build target wasm32-wasi
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build target wasm32-wasi
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build target wasm32-wasi
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Intra-doc links
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Intra-doc links
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Bitrot check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Bitrot check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Bitrot check
virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
|
|
Bitrot check:
halo2_proofs/src/multicore.rs#L16
unused import: `Scope`
|
|
Bitrot check:
halo2_proofs/src/dev/cost.rs#L105
unused doc comment
|
|
Bitrot check:
halo2_proofs/src/dev/cost.rs#L107
unused doc comment
|
|
Bitrot check:
halo2_proofs/src/dev/cost.rs#L109
unused doc comment
|
|
Bitrot check:
halo2_proofs/src/plonk/permutation.rs#L85
method `commitments` is never used
|
|
Bitrot check
`halo2_proofs` (lib) generated 5 warnings (run `cargo fix --lib -p halo2_proofs` to apply 1 suggestion)
|
|
Bitrot check:
halo2_gadgets/src/endoscale/chip/alg_1.rs#L216
use of deprecated associated function `std::array::IntoIter::<T, N>::new`: use `IntoIterator::into_iter` instead
|
|
Bitrot check:
halo2_gadgets/src/utilities/bitstring.rs#L51
variable does not need to be mutable
|
|
Bitrot check:
halo2_gadgets/src/utilities/bitstring.rs#L60
variable does not need to be mutable
|
|
Test on windows-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on windows-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on windows-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on windows-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on windows-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on macOS-latest with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on macOS-latest with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on macOS-latest with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on macOS-latest with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on macOS-latest with beta features
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on windows-latest with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on windows-latest with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on windows-latest with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on windows-latest with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on windows-latest with beta features
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on windows-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on windows-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on windows-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on windows-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on windows-latest with nightly features
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on ubuntu-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest with nightly features
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on macOS-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on macOS-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on macOS-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on macOS-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on macOS-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on i686-unknown-linux-gnu
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on i686-unknown-linux-gnu
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on i686-unknown-linux-gnu
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on i686-unknown-linux-gnu
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on i686-unknown-linux-gnu
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on ubuntu-latest with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest with beta features
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on macOS-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on macOS-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on macOS-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on macOS-latest with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on macOS-latest with nightly features
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on i686-unknown-linux-gnu with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on i686-unknown-linux-gnu with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on i686-unknown-linux-gnu with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on i686-unknown-linux-gnu with nightly features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on i686-unknown-linux-gnu with nightly features
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on i686-unknown-linux-gnu with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on i686-unknown-linux-gnu with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on i686-unknown-linux-gnu with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on i686-unknown-linux-gnu with beta features
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on i686-unknown-linux-gnu with beta features
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Code coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Code coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Code coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Code coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Code coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Code coverage
virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
|