Fix MavenProjectSupplier to work properly on windows (port 498) #594
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-grecourt
changed the title
batsatt
approved these changes
Jan 3, 2022
Fix MavenProjectSupplier to work properly on windows. Project config 'project.resourcedirs' is split using ':', however that conflicts with windows drive notation. Fixes helidon-io#357 helidon-io#483
romain-grecourt
force-pushed
the
forward-port-498
branch
from
2be4fcb
to
fa06715
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port #498
Fix MavenProjectSupplier to work properly on windows.
Project config 'project.resourcedirs' is split using ':', however that conflicts with windows drive notation.
Fixes #357 #483