Double-slash URI issue #7474

helidon-io · Sep 24, 2023 · 8b9e092 · 8b9e092
1 parent 85f5202
commit 8b9e092
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/common/uri/src/main/java/io/helidon/common/uri/UriPathNoParam.java b/common/uri/src/main/java/io/helidon/common/uri/UriPathNoParam.java
@@ -73,7 +73,7 @@ public String rawPathNoParams() {
     @Override
     public String path() {
         if (decodedPath == null) {
-            decodedPath = decode(rawPath);
+            decodedPath = decode(rawPath, false);
         }
         return decodedPath;
     }
@@ -104,11 +104,11 @@ public String toString() {
     @Override
     public void validate() {
         if (decodedPath == null) {
-            this.decodedPath = URI.create(rawPath).normalize().getPath();
+            this.decodedPath = decode(rawPath, true);
         }
     }
 
-    private static String decode(String rawPath) {
+    private static String decode(String rawPath, boolean validate) {
         /*
         Raw path may:
          - be encoded (%20)
@@ -121,10 +121,15 @@ private static String decode(String rawPath) {
         int dot = rawPath.indexOf(".");
         int doubleSlash = rawPath.indexOf("//");
 
-        if (percent == -1 && doubleSlash == -1 && dot == -1) {
+        if (!validate && percent == -1 && doubleSlash == -1 && dot == -1) {
             return rawPath;
         }
 
+        if (doubleSlash == 0) {
+            // JDK-8316799 URI.create("//foo/bar").normalize().getPath() --> "/bar"
+            rawPath = rawPath.substring(1);
+        }
+
         return URI.create(rawPath).normalize().getPath();
     }
 }
diff --git a/common/uri/src/test/java/io/helidon/common/uri/UriPathTest.java b/common/uri/src/test/java/io/helidon/common/uri/UriPathTest.java
@@ -17,6 +17,8 @@
 package io.helidon.common.uri;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
@@ -37,4 +39,16 @@ void testEncodeSpace() {
         assertThat(path.path(), is("/my path"));
         assertThat(path.rawPath(), is("/my%20path"));
     }
+
+    @ParameterizedTest
+    @ValueSource(strings = {
+            "//foo/bar",
+            "//foo//bar",
+            "/foo//bar",
+            "/foo/bar",
+    })
+    void testDoubleSlash(String rawPath) {
+        UriPath path = UriPath.create(rawPath);
+        assertThat(path.path(), is("/foo/bar"));
+    }
 }