Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring based on development guidelines #146

Closed
m0mus opened this issue Nov 1, 2018 · 2 comments
Closed

Refactoring based on development guidelines #146

m0mus opened this issue Nov 1, 2018 · 2 comments
Assignees
Projects

Comments

@m0mus
Copy link
Contributor

m0mus commented Nov 1, 2018

No description provided.

@m0mus m0mus created this issue from a note in Team Board (To do) Nov 1, 2018
@tomas-langer
Copy link
Member

The following tasks are part of this issue ("Validate" means check and if not compliant, fix):

  • Change builders that accept other builders to accept a supplier instead
  • Change scope to "provided" where reasonable to have a cleaner dependency graph
  • Fix bundle dependency in MP security (brings in too many third party libraries)
  • Move SE bundles to a /bundles root module and change group ids accordingly
  • Remove Google Login from security bundle (third party dependencies)
  • Fix module names and package names in security/providers and security/abac (and validate other modules adhere to dev guidelines)
  • Validate that config is expected to be on the node of the component, rather then on the root (e.g. for security, the config should be on a node that contains "providers")
  • Validate naming convention of configuration keys used by components
  • Fix inconsistencies in getter and setter names
  • Validate we do not create instances using "new" and use factory methods
  • Refactor factory method names (use create)
  • Refactor config methods in builders (use config)
  • Validate java module files are in each module
  • Refactor unit tests to use Hamcrest assertions

tomas-langer added a commit to tomas-langer/helidon that referenced this issue Nov 12, 2018
Removed SpiHelper (not working in Java 9+)
Related to helidon-io#146
tomas-langer added a commit to tomas-langer/helidon that referenced this issue Nov 12, 2018
tomas-langer added a commit to tomas-langer/helidon that referenced this issue Nov 12, 2018
Renamed getters (including in common configurable)
Renamed factory methods
Renamed builder methods with config
Builders now implement common Builder
Related to helidon-io#146
tomas-langer added a commit to tomas-langer/helidon that referenced this issue Nov 12, 2018
Renamed getters
Renamed factory methods
Using builder pattern
Related to helidon-io#146
tomas-langer added a commit that referenced this issue Nov 15, 2018
Removed SpiHelper (not working in Java 9+)
Related to #146
tomas-langer added a commit that referenced this issue Nov 15, 2018
tomas-langer added a commit that referenced this issue Nov 15, 2018
Renamed getters (including in common configurable)
Renamed factory methods
Renamed builder methods with config
Builders now implement common Builder
Related to #146
tomas-langer added a commit that referenced this issue Nov 15, 2018
Renamed getters
Renamed factory methods
Using builder pattern
Related to #146
@barchetta barchetta moved this from To do to In progress in Team Board Nov 15, 2018
@tomas-langer
Copy link
Member

Fixed all issues spawned from this one.

Team Board automation moved this from In progress to Done Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Team Board
  
Done
Development

No branches or pull requests

2 participants