Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing config updates in archetype #4892

Closed
arjav-desai opened this issue Sep 15, 2022 · 1 comment
Closed

Tracing config updates in archetype #4892

arjav-desai opened this issue Sep 15, 2022 · 1 comment
Assignees
Labels
archetypes bug Something isn't working P2 tracing
Projects

Comments

@arjav-desai
Copy link
Member

If we select tracing while generating either SE or MP, the tracing config is added to k8s yaml instead of config files. While this will be fixed as part of #4887 and #4891, we need to make sure tracing config is added at right location i.e. config file where it belongs.

Also, currently tracing config is generated only in yaml format but it should be generated in properties format for MP, see https://github.com/oracle/helidon/blob/helidon-3.x/archetypes/helidon/src/main/archetype/common/observability.xml

It would make sense to have SE and MP level config moved from common to those respective flavors.

@arjav-desai arjav-desai added this to Triage in Backlog via automation Sep 15, 2022
@m0mus m0mus added P2 bug Something isn't working labels Sep 26, 2022
@m0mus m0mus moved this from Triage to High priority in Backlog Sep 26, 2022
@tvallin
Copy link
Member

tvallin commented Oct 10, 2022

closed by #5001

@tvallin tvallin closed this as completed Oct 10, 2022
Backlog automation moved this from High priority to Closed Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archetypes bug Something isn't working P2 tracing
Projects
Backlog
  
Closed
Development

No branches or pull requests

3 participants