Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing config updates in archetype #5001

Merged
merged 2 commits into from Oct 8, 2022

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Sep 29, 2022

See #4892

Signed-off-by: tvallin thibault.vallin@oracle.com

Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin
Copy link
Member Author

tvallin commented Sep 29, 2022

Hi @arjav-desai,
Here is some work to update tracing configuration in archetypes. I am still testing manually but I thought in the mean time you could have a look if it matches your expectation.

@arjav-desai
Copy link
Member

Hi @arjav-desai, Here is some work to update tracing configuration in archetypes. I am still testing manually but I thought in the mean time you could have a look if it matches your expectation.

So far looks good to me. Was there something to be set/mentioned about tracing in README files generated as well?

@romain-grecourt romain-grecourt marked this pull request as ready for review October 3, 2022 23:19
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@romain-grecourt romain-grecourt merged commit a072fe8 into helidon-io:main Oct 8, 2022
@tvallin tvallin deleted the archetype_tracing branch October 9, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants