Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pico Config Improvements #6768

Closed
2 tasks
Tracked by #6274
trentjeff opened this issue May 4, 2023 · 2 comments · May be fixed by #8400
Closed
2 tasks
Tracked by #6274

Pico Config Improvements #6768

trentjeff opened this issue May 4, 2023 · 2 comments · May be fixed by #8400
Assignees
Labels
4.x Version 4.x config declarative Helidon Declarative
Milestone

Comments

@trentjeff
Copy link
Member

trentjeff commented May 4, 2023

Config improvements:
Currently we need to set the config through bootstrap. I think we should a concept of two configs:

  • a bootstrap config (by default only uses system properties and env vars) to prepare pico
  • a config that is constructed as a Service in Pico (and can use other services, such as ConfigSource, Mapper etc.) to create the configuration tree for runtime
@trentjeff trentjeff mentioned this issue May 4, 2023
5 tasks
@trentjeff trentjeff added config 4.x Version 4.x declarative Helidon Declarative labels May 4, 2023
@trentjeff trentjeff added this to the 4.0.0-RC1 milestone May 4, 2023
@trentjeff trentjeff self-assigned this Jun 21, 2023
@tomas-langer
Copy link
Member

We currently support creating Config as a service in registry.
It now only supports custom ConfigSource

@tomas-langer
Copy link
Member

The new configuration approach for helidon-service-inject supports both configuration created by user and registered through GlobalConfig and a configuration created within the service registry.
The "bootstrap" configuration will use either the global config (if present), or a new configuration instance created through Config.create().
The "in-registry" config instance gathers services for the registry itself (such as parsers, filters, sources etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x config declarative Helidon Declarative
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants