Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeInfo and TypedElementName needs work #6769

Closed
trentjeff opened this issue May 4, 2023 · 0 comments
Closed

TypeInfo and TypedElementName needs work #6769

trentjeff opened this issue May 4, 2023 · 0 comments
Assignees
Labels
4.x Version 4.x
Projects
Milestone

Comments

@trentjeff
Copy link
Member

trentjeff commented May 4, 2023

  1. TypedElementName -> TypedElementInfo

  2. Add AnnotationAndValue#defaultValues(). This way we can see if values() are the same as defaultValues().
    deferred to a new issue: Add AnnotationAndValue#defaultValues() #6840

  3. rename TypeInfo#elementInfo() -> interestingElementInfo.

  4. add TypeInfo#allElementInfo() ->

    /**
     * The elements that make up the type that are relevant for processing.
     *
     * @return the elements that make up the type that are relevant for processing
     */
    List<TypedElementName> elementInfo(); // <-- and will be renamed to interestingElementInfo()

    /**
     * The elements that make up this type that are considered "other", or being skipped because they are irrelevant to
     * processing.
     *
     * @return the elements that still make up the type, but are otherwise deemed irrelevant for processing
     */
    List<TypedElementName> otherElementInfo();
@trentjeff trentjeff self-assigned this May 4, 2023
@trentjeff trentjeff added the 4.x Version 4.x label May 4, 2023
@github-actions github-actions bot added this to Triage in Backlog May 4, 2023
@trentjeff trentjeff modified the milestones: 4.0.0-M2, 4.0.0-M1 May 4, 2023
@trentjeff trentjeff moved this from Triage to Normal priority in Backlog May 4, 2023
@trentjeff trentjeff changed the title TypedElementName needs work TypeInfo and TypedElementName needs work May 17, 2023
@trentjeff trentjeff moved this from Normal priority to Sprint Scope in Backlog May 17, 2023
trentjeff added a commit to trentjeff/helidon that referenced this issue May 18, 2023
trentjeff added a commit that referenced this issue May 18, 2023
Backlog automation moved this from Sprint Scope to Closed May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x
Projects
Backlog
  
Closed
Development

No branches or pull requests

1 participant