[3.x] WLS JMS connector doesn't support named factory bean

[danielkec]

Reported by @msinghal123

Environment Details

• Helidon Version: 3.x, 4.x

---

Problem Description

Due the fact that jndi setting takes precedent over named factory and WLS connector adds implicit jndi props, named factories are always ignored.

[danielkec]

Index: messaging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/ConnectionContext.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/messaging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/ConnectionContext.java b/messaging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/ConnectionContext.java
--- a/messaging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/ConnectionContext.java	(revision 8fe2a51a8fe596a682fda2bd8aa2a049b083d725)
+++ b/messaging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/ConnectionContext.java	(date 1684416689594)
@@ -32,11 +32,7 @@
 import jakarta.jms.ConnectionFactory;
 import jakarta.jms.Destination;
 
-import static io.helidon.messaging.connectors.jms.JmsConnector.JNDI_ATTRIBUTE;
-import static io.helidon.messaging.connectors.jms.JmsConnector.JNDI_DESTINATION_ATTRIBUTE;
-import static io.helidon.messaging.connectors.jms.JmsConnector.JNDI_JMS_FACTORY_ATTRIBUTE;
-import static io.helidon.messaging.connectors.jms.JmsConnector.JNDI_JMS_FACTORY_DEFAULT;
-import static io.helidon.messaging.connectors.jms.JmsConnector.JNDI_PROPS_ATTRIBUTE;
+import static io.helidon.messaging.connectors.jms.JmsConnector.*;
 
 /**
  * Context related to one actual connection being constructed by JMS connector.
@@ -69,7 +65,8 @@
     }
 
     boolean isJndi() {
-        return config.get(JNDI_ATTRIBUTE).exists();
+        return config.get(JNDI_ATTRIBUTE).exists()
+                && !config.get(NAMED_FACTORY_ATTRIBUTE).exists();
     }
 
     Optional<? extends ConnectionFactory> lookupFactory() {