comment out docs and sitegen plugin for now #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-grecourt
added a commit
that referenced
this pull request
Jan 10, 2019
- move sources from webserver/netty to webserver/webserver - leave the SPI for now - remove all dependencies to webserver-netty - remove webserver/netty from the reactor - delete webserver/netty
romain-grecourt
added a commit
that referenced
this pull request
Jan 10, 2019
* webserver-netty removal, step #1: - move sources from webserver/netty to webserver/webserver - leave the SPI for now - remove all dependencies to webserver-netty - remove webserver/netty from the reactor - delete webserver/netty * move webserver/test-support/src/main/resources/s-internal -> webserver/test-support/src/test/resources/ * Remove cyclic dependency between webserver and webserver-test-support: - move io.helidon.webserver.testsupport.SocketHttpClient.java to webserver/src/test/java/ since it's only used in webserver - remove the use of LoggingTestUtils from webserver * Remove webserver SPI: - move BareRequest and BareResponse to io.helidon.webserver package - remove WebServerFactory - remove io.helidon.webserver.netty.Factory - update WebServer.Builder.build to use new NettyWebServer - make NettyWebServer public instead of package protected, make cstructor public * fix copyright and checkstyles * remove occurrence of helidon-webserver-netty in the docs * remove META-INF/services/io.helidon.webserver.spi.WebServerFactory * fix remaining errors related to WebServer SPI removal * fix checkstyle error in TestClient * fix copyright years to have the preffered form * PR feedback: refactor io.helidon.webserver.netty into io.helidon.webserver * fix checkstyle error in NettyWebServer
akarnokd
referenced
this pull request
in akarnokd/helidon
Feb 22, 2020
Include helidon-io#1429 for a known good Multi.from implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.