Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reactive] Reimplement Microprofile-RS, fix operators, add from(CS) #1511

Merged
merged 16 commits into from
Mar 23, 2020

Conversation

akarnokd
Copy link
Collaborator

This PR reimplements the Microprofile Reactive Streams adapter of Helidon.

  • Fix iterator failure not cancelling the flow in Multi.flatMapIterable.
  • Fix Multi.flatMap not properly accounting items emitted.
  • Add from(CompletionStage) implementation (Related: More reactive operators (tracking issue) #1500) required by MPRS.
  • Expose onCancel.
  • Fix OnErrorResumeNext possibly trying to self-suppress.

@akarnokd
Copy link
Collaborator Author

[ERROR] /pipeline/source/microprofile/reactive-streams/src/main/java/io/helidon/microprofile/reactive/HelidonReactiveStreamsEngine.java:129:5: Method length is 352 lines (max allowed is 150). [MethodLength]

I don't know what to do. The method is basically a large switch-case because of the sheer number of Stage to support of MPRS.

@danielkec danielkec self-assigned this Mar 13, 2020
@danielkec danielkec added the reactive Reactive streams and related components label Mar 13, 2020
@danielkec danielkec added this to the 2.0.0 milestone Mar 13, 2020
@akarnokd
Copy link
Collaborator Author

I try my best to make this work but the full project doesn't build on Windows so my only feedback is from the CI failures.

@romain-grecourt
Copy link
Contributor

@akarnokd some fixes for the windows build are underway, hopefully it's going to be fixed soon.

@akarnokd
Copy link
Collaborator Author

@danielkec Could you look into that failure with the InternalProcessor overflowing some queue?

@danielkec
Copy link
Contributor

@danielkec Could you look into that failure with the InternalProcessor overflowing some queue?

@akarnokd Sure fix is already prepared at #1499

@danielkec danielkec mentioned this pull request Mar 18, 2020
akarnokd added a commit to akarnokd/helidon that referenced this pull request Mar 19, 2020
danielkec pushed a commit that referenced this pull request Mar 21, 2020
@danielkec danielkec merged commit f31be2a into helidon-io:master Mar 23, 2020
@akarnokd akarnokd deleted the HelidonMicroprofileRSReimplement branch March 25, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reactive Reactive streams and related components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants