add initial proposal for multipart support #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-grecourt
requested review from
ljnelson,
spericas,
barchetta,
m0mus,
tomas-langer and
tjquinno
- remove BufferedMultiPart.content() this can be done transparently by the writer for that entity type Fix typo BodyPart.Builder.builder() -> BodyPart.Builder.build()
spericas
reviewed
Nov 14, 2018
spericas
reviewed
Nov 14, 2018
spericas
reviewed
Nov 14, 2018
spericas
reviewed
Nov 14, 2018
spericas
reviewed
Nov 14, 2018
spericas
reviewed
Nov 14, 2018
tjquinno
reviewed
Nov 14, 2018
- Remove BodyPart.request() and BodyPart.response(), it's un-necessary - Move the open issue for error handling into a sub-section with small note that this is different than for any other supported media types - Move the open issue for HTTP2 support into a sub-section with a mini-summary of Santiago's comment - Add a sub-section for generic type mapping with an example and a note that this may be implemented in a future release
This was referenced Nov 15, 2018
tomas-langer
requested changes
Nov 16, 2018
…r the reactive model
tomas-langer
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #147