Implementation of MP FT 2.1.1 using FT SE #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nous. Passing unit tests FallbackTest, RetryTest and AsynchronousTest. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…fied ErrorChecker to use subtyping instead of equality when comparing exceptions. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…T annotations. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
- Support for sync (no queues) in Bulkhead - Fixed validation in FallbackAntn - Fixes to CommandRunner async support - Some changes in unit tests while preserving coverage All unit tests for Timeout, Fallback, Retry, Asynchronous, Bulkhead and CircuitBreaker are passing. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
- Support for metrics for all primitives except bulkheads - Changes to SE Retry to count number of retries - Some test fixes Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
- New method in Bulkhead to return stats - Support for all metrics related to bulkheads - Some minor test changes Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…CKs, only the CDI request scope is active. Temporarily disable annotation validation in CDI extension as this now causes TCKs to fail validation before running. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…n and then applyOn sets. Updates to some tests. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…tionStage<?>. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
- Handle timeouts when a method catches InterruptedException - Changes to SE FT to support some event listeners - Create handlers for each invocation while sharing those for Bulkheads and CircuitBreakers - Renamed CommandRunner to MethodInvoker Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
changed the title
danielkec
reviewed
Sep 10, 2020
Comment on lines
36
to
49
| CompletableFuture<T> future = new CompletableFuture<>(); | ||
| AsyncTask<T> task = new AsyncTask<>(supplier, future); | ||
|
|
||
| Future<?> taskFuture; | ||
| try { | ||
| executor.get().submit(task); | ||
| taskFuture = executor.get().submit(task); | ||
| } catch (Throwable e) { | ||
| // rejected execution and other executor related issues | ||
| return Single.error(e); | ||
| } | ||
|
|
||
| return Single.create(future); | ||
| Single<T> single = Single.create(future, true); | ||
| single.onCancel(() -> taskFuture.cancel(false)); // cancel task | ||
| return single; |
There was a problem hiding this comment.
This looks like duplication of CompletableFuture.supplyAsync internals, is there some AsyncTask's feature I missed @tomas-langer, or we can simplify?
public <T> Single<T> invoke(Supplier<T> supplier) {
try {
return Single.create(CompletableFuture.supplyAsync(task, executor.get()), true);
} catch (Throwable e) {
// rejected execution and other executor related issues
return Single.error(e);
}
}There was a problem hiding this comment.
Maybe, but not sure it is more readable tbh
There was a problem hiding this comment.
Code has changed now, see below
danielkec
reviewed
Sep 10, 2020
fault-tolerance/src/main/java/io/helidon/faulttolerance/ErrorChecker.java
Outdated
Show resolved
Hide resolved
akarnokd
reviewed
Sep 10, 2020
fault-tolerance/src/main/java/io/helidon/faulttolerance/AsyncImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
fault-tolerance/src/main/java/io/helidon/faulttolerance/ErrorChecker.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
danielkec
reviewed
Sep 14, 2020
...rofile/fault-tolerance/src/test/java/io/helidon/microprofile/faulttolerance/TimeoutTest.java
Show resolved
Hide resolved
danielkec
reviewed
Sep 14, 2020
...-tolerance/src/main/java/io/helidon/microprofile/faulttolerance/FaultToleranceExtension.java
Show resolved
Hide resolved
danielkec
reviewed
Sep 14, 2020
Comment on lines
+284
to
+289
| StringBuilder sb = new StringBuilder(); | ||
| for (int i = validFts.size() - 1; i >= 0; i--) { | ||
| sb.append(validFts.get(i).toString()); | ||
| sb.append("\n"); | ||
| } | ||
| return sb.toString(); |
There was a problem hiding this comment.
validFts is always LinkedList, using descendingIterator would be nice
danielkec
approved these changes
Sep 14, 2020
This was referenced Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing FailSafe and Hystrix by our own implementation of FT primitives. Some minor changes to our first version of these primitive operations was necessary to be fully compatible with MP and pass all the TCKs.