Prepare RegistryFactory lazily to use the most-recently-assigned MetricsSettings #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…val so as to use the latest-provided MetricsSettings
…with the correct MetricsSettings before the producer 'clearApplicationRegistry' method is invoked
arjav-desai
pushed a commit
to arjav-desai/helidon
that referenced
this pull request
Nov 27, 2021
…icsSettings (helidon-io#3659) * Add test for overall disabled metrics * Defer creating the RegistryFactory INSTANCE until first actual retrieval so as to use the latest-provided MetricsSettings * Reorder some code so the metrics CDI initialized the RegistryFactory with the correct MetricsSettings before the producer 'clearApplicationRegistry' method is invoked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3653
The prior implementation used a static initializer to create a
RegistryFactoryusing defaultMetricsSettings(which would imply that metrics would be enabled). Even though subsequentRegistryFactory#getInstance(MetricsSettings)calls would correctly communicate if metrics had been disabled, by this time the full-featured registry had already been created and saved as the singleton instance. That would mean we would lose some of the efficiency of the minimal metrics implementation when metrics is configured as disabled.This PR changes the code to lazily create the singleton on first retrieval, using the latest
MetricsSettingspassed toRegistryFactory#getInstance().