Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add robustness to some of the timing-susceptible metrics tests; add util matcher with retry #5032

Merged
merged 2 commits into from Sep 30, 2022
Merged

Add robustness to some of the timing-susceptible metrics tests; add util matcher with retry #5032

merged 2 commits into from Sep 30, 2022

Conversation

tjquinno
Copy link
Member

Resolves #4982
Resolves #4976
Resolves #5030

This PR:

  1. adds a new custom Hamcrest matcher that retries a number of times with a delay, both settable using system properties, and
  2. updates several metrics tests to use the new matcher methods.

Signed-off-by: tim.quinn@oracle.com tim.quinn@oracle.com

@tjquinno
Add robustness to some of the timing-susceptible metrics tests; add u…
2f9f3ed 
…til matcher with retry

Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
@tjquinno tjquinno self-assigned this Sep 30, 2022
@romain-grecourt romain-grecourt merged commit ce733cb into helidon-io:main Sep 30, 2022
@tjquinno tjquinno deleted the intermittent-metrics-tests-main branch October 1, 2022 05:12
@tjquinno tjquinno mentioned this pull request Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

@ljnelson ljnelson Awaiting requested review from ljnelson

Assignees

@tjquinno tjquinno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tjquinno @romain-grecourt