Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ServerConfiguration.builder() on WebServer.builder() in docs (#5023) #5121

Merged
merged 1 commit into from
Oct 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/se/health.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ Routing defaultRouting = Routing.builder()
.build();

WebServer server = WebServer.builder(defaultRouting)
.config(ServerConfiguration.builder()
.config(WebServer.builder()
.port(8080) // <6>
.addSocket("health", SocketConfiguration.builder() // <7>
.port(8081)
Expand Down
10 changes: 5 additions & 5 deletions docs/se/tracing.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,11 @@ Helidon provides such an implementation for:
[source,java]
.Configuring OpenTracing `Tracer`
----
ServerConfiguration.builder()
.tracer(TracerBuilder.create("my-application") // <1>
.collectorUri(URI.create("http://10.0.0.18:9411")) // <2>
.build())
.build()
WebServer.builder()
.tracer(TracerBuilder.create("my-application") // <1>
.collectorUri(URI.create("http://10.0.0.18:9411")) // <2>
.build())
.build()
----
<1> The name of the application (service) to associate with the tracing events
<2> The endpoint for tracing events, specific to the tracer used, usually loaded from Config
Expand Down
2 changes: 1 addition & 1 deletion tracing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ pom.xml:

code using config:
```java
return ServerConfiguration.builder()
return WebServer.builder()
.config(config.get("webserver"))
.tracer(TracerBuilder.create(config.get("tracing"))
.buildAndRegister())
Expand Down