SSE API and implementation in Nima #6096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…ponding location.
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
… be given a different media type for serialization. Additional testing.
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…e class to implement SseSink.
…s request information.
…SE. Lots of refactoring and a new test.
…IDs, etc. Fixed pom problem.
tomas-langer
requested changes
Feb 14, 2023
nima/sse/common/src/main/java/io/helidon/nima/sse/common/SseEvent.java
Outdated
Show resolved
Hide resolved
nima/sse/common/src/main/java/io/helidon/nima/sse/common/SseEvent.java
Outdated
Show resolved
Hide resolved
nima/sse/common/src/main/java/io/helidon/nima/sse/common/SseEvent.java
Outdated
Show resolved
Hide resolved
nima/sse/webserver/src/main/java/io/helidon/nima/sse/webserver/SseSinkProvider.java
Outdated
Show resolved
Hide resolved
nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/http/spi/SourceHandler.java
Outdated
Show resolved
Hide resolved
nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/http/spi/SourceHandler.java
Outdated
Show resolved
Hide resolved
nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/http1/ClientResponseImpl.java
Outdated
Show resolved
Hide resolved
nima/webserver/webserver/src/main/java/io/helidon/nima/webserver/http/spi/SinkProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tomas-langer
previously requested changes
Feb 21, 2023
nima/sse/webclient/src/main/java/io/helidon/nima/sse/webclient/SseSourceHandlerProvider.java
Outdated
Show resolved
Hide resolved
danielkec
reviewed
Feb 22, 2023
nima/sse/webserver/src/main/java/io/helidon/nima/sse/webserver/SseSinkProvider.java
Outdated
Show resolved
Hide resolved
danielkec
reviewed
Feb 22, 2023
nima/sse/webclient/src/main/java/io/helidon/nima/sse/webclient/SseSource.java
Outdated
Show resolved
Hide resolved
…erface. New test.
danielkec
previously approved these changes
Feb 23, 2023
…A few more tests.
…fy unexpected conditions.
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
This was referenced Feb 27, 2023
danielkec
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New SSE API for Nima. Defines classes
SseSink,SseSourceandSseEvent. Uses SPIs in WebServer and WebClient to load SSE support if available in classpath. Fully integrated with Nima's media context infrastructure, so each event can be serialized or deserialized with a writer or a reader, respectively.Fixes #5666