Improve ClientRequestImpl #6208

klustria · 2023-02-15T17:10:11Z

Change includes the following:

Configurable value for mediaContext, maxHeaderSize, maxStatusLength, sendExpect100Continue, and validateHeaders
Optimize chunk request in ClientConnectionOutputStream, i.e. don't chunk if data is small
Send expect-100 (configurable via sendExpect100Continue) to verify host responsiveness before sending chunk request
Configurable http connection queue limit
Added read/connection timeouts in the connection queue key
Request using HEAD method will be allowed only with no entity
Mocked unit test and Integration test to validate code changes

Change includes the following: 1. Configurable value for mediaContext, maxHeaderSize, maxStatusLength, sendExpect100Continue, and validateHeaders 2. Optimize chunk request in ClientConnectionOutputStream, i.e. don't chunk if data is small 3. Send expect-100 (configurable via sendExpect100Continue) to verify host responsiveness before sending chunk request 4. Replace ConcurrentLinkedDeque in ClientConnectionOutputStream.getConnection() with LinkedBlockingDeque, so it can be optionally be bounded

…requestimpl-4.x

…dates, and various code style updates

klustria · 2023-02-17T17:46:26Z

The build failure in https://github.com/helidon-io/helidon/actions/runs/4202519142/jobs/7298843034 is due to this issue: #5386

…requestimpl-4.x

…tion unit test

…requestimpl-4.x

klustria · 2023-02-21T19:10:11Z

The build failure in https://github.com/helidon-io/helidon/actions/runs/4202519142/jobs/7298843034 is due to this issue: #5386

This has been fixed.

...webclient/webclient/src/test/java/io/helidon/nima/webclient/http1/ClientRequestImplTest.java

nima/tests/integration/webclient/webclient/src/test/resources/logging-test.properties

…oken pipe failure.

… test problem.

…requestimpl-4.x

…t failure.

…questImpl and both ClientRequestImplTests

...webclient/webclient/src/test/java/io/helidon/nima/webclient/http1/ClientRequestImplTest.java

nima/tests/integration/webclient/webclient/src/test/resources/logging-test.properties

...webclient/webclient/src/main/java/io/helidon/nima/webclient/http1/Http1ClientConnection.java

…epAliveTest and re-enable all unit tests.

…requestimpl-4.x

…hod.

…er log method used with lambda to avoid if condition

…requestimpl-4.x

...webclient/webclient/src/test/java/io/helidon/nima/webclient/http1/ClientRequestImplTest.java

…his.

…requestimpl-4.x

nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/http1/Http1Client.java

...webclient/webclient/src/test/java/io/helidon/nima/webclient/http1/ClientRequestImplTest.java

…requestimpl-4.x

…erator more readable

…requestimpl-4.x

…ach of the webclient builder calls.

… http1 client.

nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/http1/ClientRequestImpl.java

nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/http1/Http1Client.java

...webclient/webclient/src/test/java/io/helidon/nima/webclient/http1/ClientRequestImplTest.java

Tomas is on vacation and this was already reviewed by Santiago, David and Daniel

oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 15, 2023

klustria added 2 commits February 15, 2023 11:17

Merge remote-tracking branch 'upstream/main' into 5386-improve-client…

3611c75

…requestimpl-4.x

Improve Http1Client builder javadoc comments

890361f

klustria self-assigned this Feb 15, 2023

klustria added 2 commits February 17, 2023 01:29

Merge remote-tracking branch 'upstream/main' into 5386-improve-client…

18d0075

…requestimpl-4.x

Validate methods with no entity, Connection queue limit, copyright up…

b7f7713

…dates, and various code style updates

klustria requested a review from tomas-langer February 17, 2023 09:46

klustria added 3 commits February 20, 2023 14:51

Merge remote-tracking branch 'upstream/main' into 5386-improve-client…

511eb66

…requestimpl-4.x

Improve connection queue size limit, add mocked unit test and integra…

cf2cd14

…tion unit test

Merge remote-tracking branch 'upstream/main' into 5386-improve-client…

98f5fe0

…requestimpl-4.x

klustria mentioned this pull request Feb 21, 2023

Nima: ClientRequestImpl #5386

Closed

Add webclient in the Helidon Nima Test Integration Project

b2a6bb9

tomas-langer previously requested changes Feb 22, 2023

View reviewed changes

klustria added 9 commits February 21, 2023 19:37

Refactor for readability and further improve unit tests

9bb796d

Call release rather than close in finishRequest to debug unit test br…

1b55e45

…oken pipe failure.

Increase connection queue size to debug broken pipe unit test failure

bd5cd84

Rollback Http1ClientConnection to isolate if this is the cause of the…

d7934b8

… test problem.

Merge remote-tracking branch 'upstream/main' into 5386-improve-client…

1c7a2e2

…requestimpl-4.x

Rollback ClientRequestImpl to isolate if this is the cause of the tes…

89b7401

…t failure.

Fix copyright for rolled back Http1ClientConnection

d0916fd

Return all changes to Http1ClientConnectionClient and adjust ClientRe…

02822c8

…questImpl and both ClientRequestImplTests

Add connection queue size and expand keepAliveKey

994a13f

spericas reviewed Feb 24, 2023

View reviewed changes

...webclient/webclient/src/test/java/io/helidon/nima/webclient/http1/ClientRequestImplTest.java Outdated Show resolved Hide resolved

spericas reviewed Feb 24, 2023

View reviewed changes

...webclient/webclient/src/test/java/io/helidon/nima/webclient/http1/ClientRequestImplTest.java Outdated Show resolved Hide resolved

spericas reviewed Feb 24, 2023

View reviewed changes

nima/tests/integration/webclient/webclient/src/test/resources/logging-test.properties Outdated Show resolved Hide resolved

spericas reviewed Feb 24, 2023

View reviewed changes

...webclient/webclient/src/main/java/io/helidon/nima/webclient/http1/Http1ClientConnection.java Outdated Show resolved Hide resolved

spericas reviewed Feb 24, 2023

View reviewed changes

...webclient/webclient/src/main/java/io/helidon/nima/webclient/http1/Http1ClientConnection.java Outdated Show resolved Hide resolved

klustria added 6 commits February 27, 2023 10:52

Disable sendExpect100Continue for now because it is causing server Ke…

d46fd47

…epAliveTest and re-enable all unit tests.

Merge remote-tracking branch 'upstream/main' into 5386-improve-client…

61c60d3

…requestimpl-4.x

Minor update to remove unnecessary use of this when calling close met…

bcb68ed

…hod.

ConsoleHandler log level is toned down and Http1ClientConnection logg…

c0c0d1c

…er log method used with lambda to avoid if condition

Merge remote-tracking branch 'upstream/main' into 5386-improve-client…

381a220

…requestimpl-4.x

Use @servertest for testing and reinstate disabled tests

c0ec7a4

klustria requested review from spericas and Verdent February 28, 2023 06:42

danielkec reviewed Feb 28, 2023

View reviewed changes

...webclient/webclient/src/test/java/io/helidon/nima/webclient/http1/ClientRequestImplTest.java Outdated Show resolved Hide resolved

klustria added 2 commits February 28, 2023 09:21

Make http handlers throwable with IOException since NIMA can handle t…

3fd5960

…his.

Merge remote-tracking branch 'upstream/main' into 5386-improve-client…

2e57106

…requestimpl-4.x

klustria requested a review from danielkec February 28, 2023 17:25

Verdent reviewed Mar 1, 2023

View reviewed changes

nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/http1/Http1Client.java Outdated Show resolved Hide resolved

spericas reviewed Mar 1, 2023

View reviewed changes

...webclient/webclient/src/test/java/io/helidon/nima/webclient/http1/ClientRequestImplTest.java Outdated Show resolved Hide resolved

spericas reviewed Mar 1, 2023

View reviewed changes

...webclient/webclient/src/test/java/io/helidon/nima/webclient/http1/ClientRequestImplTest.java Outdated Show resolved Hide resolved

klustria added 2 commits March 1, 2023 07:31

Change getter methods in Http1Client from public to package local

fdd4151

Merge remote-tracking branch 'upstream/main' into 5386-improve-client…

9a6f1c1

…requestimpl-4.x

klustria requested a review from Verdent March 1, 2023 15:34

Inject Http1Client into the constructor and make ? : conditional op…

af3ac89

…erator more readable

klustria requested a review from spericas March 1, 2023 15:49

klustria added 5 commits March 1, 2023 08:00

Another adjustment to make ? : conditional operator more readable

9eb7399

Remove host information from the URL path of the injected client.

a19f2e9

Merge remote-tracking branch 'upstream/main' into 5386-improve-client…

9d37efd

…requestimpl-4.x

Formulate baseURI from the constructor rather than when using it in e…

3516f55

…ach of the webclient builder calls.

Rename injected http1 client to avoid confusion with the instantiated…

df08c8a

… http1 client.

spericas approved these changes Mar 2, 2023

View reviewed changes

Verdent approved these changes Mar 3, 2023

View reviewed changes

klustria merged commit dc361d4 into helidon-io:main Mar 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve ClientRequestImpl #6208

Improve ClientRequestImpl #6208

klustria commented Feb 15, 2023 •

edited

klustria commented Feb 17, 2023

klustria commented Feb 21, 2023

Improve ClientRequestImpl #6208

Improve ClientRequestImpl #6208

Conversation

klustria commented Feb 15, 2023 • edited

klustria commented Feb 17, 2023

klustria commented Feb 21, 2023

klustria commented Feb 15, 2023 •

edited