Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix {h1-prefix} unreplaced token in SE metrics guide preamble #6409

Merged

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Mar 15, 2023

Resolves #6408

Assign h1-prefix from se.doc earlier in the file.

@tjquinno tjquinno added this to the 3.2.0 milestone Mar 15, 2023
@tjquinno tjquinno self-assigned this Mar 15, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 15, 2023
@tjquinno tjquinno changed the title Assign h1-prefix from se.doc earlier Fix {h1-prefix} unreplaced token in SE metrics guide preamble Mar 15, 2023
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljamen ljamen merged commit 700ced5 into helidon-io:helidon-3.x Mar 15, 2023
@tjquinno tjquinno deleted the metrics-guide-preamble-fix-3.x branch March 15, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.x] Metrics SE guide has unreplaced token in preamble
2 participants