Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap underlying output stream with a buffered one whose buffer size is configurable #6509

Merged
merged 9 commits into from Apr 3, 2023

Conversation

spericas
Copy link
Member

@spericas spericas commented Mar 29, 2023

Wrap underlying output stream with a buffered one whose buffer size is configurable. Using a buffered stream prevents bad interactions between Nagle's algorithm and delayed ACKs in TCP. Drop extra buffering in encoders to avoid double buffering. Minor fix in the ListenerConfiguration class and new test.

Summary of additional changes:

  • StatusResource updated to not return an entity on a 204 status
  • Gzip and Deflate codecs modified to not use an additional buffer (to avoid double buffering)
  • ClientRequestImplTest now calls flush() explicitly
  • New call to flush() in ErrorHandlingWihtOutpuStreamTest
  • Method maxPayloadsize(long) did not return the Builder as required and was fixed
  • New test for write-buffer-size property

…rning it.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…s configurable. Using a buffered stream prevents bad interactions between with Nagle's algorithm and delayed ACKs in TCP. Drop extra buffering in encoders to avoid double buffering. Minor fix in the ListenerConfiguration class and new test.
@spericas spericas added webserver 4.x Version 4.x labels Mar 29, 2023
@spericas spericas self-assigned this Mar 29, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 29, 2023
@spericas spericas added this to Normal priority in Backlog Mar 29, 2023
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas marked this pull request as draft March 29, 2023 19:24
@spericas spericas moved this from Normal priority to Sprint Scope in Backlog Mar 30, 2023
…losed. Required for the content length optimization. Test updated.
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas marked this pull request as ready for review April 3, 2023 18:39
@spericas spericas merged commit 35fa676 into helidon-io:main Apr 3, 2023
12 checks passed
Backlog automation moved this from Sprint Scope to Closed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement. webserver
Projects
Backlog
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants