New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap underlying output stream with a buffered one whose buffer size is configurable #6509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rning it. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…s configurable. Using a buffered stream prevents bad interactions between with Nagle's algorithm and delayed ACKs in TCP. Drop extra buffering in encoders to avoid double buffering. Minor fix in the ListenerConfiguration class and new test.
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Mar 29, 2023
spericas
force-pushed
the
buffered-stream-tcp
branch
from
March 29, 2023 18:03
16cd62d
to
f50fd38
Compare
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
force-pushed
the
buffered-stream-tcp
branch
from
March 29, 2023 18:47
f50fd38
to
5d35d78
Compare
…losed. Required for the content length optimization. Test updated.
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tomas-langer
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x
Version 4.x
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
webserver
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap underlying output stream with a buffered one whose buffer size is configurable. Using a buffered stream prevents bad interactions between Nagle's algorithm and delayed ACKs in TCP. Drop extra buffering in encoders to avoid double buffering. Minor fix in the ListenerConfiguration class and new test.
Summary of additional changes:
StatusResource
updated to not return an entity on a 204 statusClientRequestImplTest
now callsflush()
explicitlyflush()
inErrorHandlingWihtOutpuStreamTest
maxPayloadsize(long)
did not return theBuilder
as required and was fixedwrite-buffer-size
property