Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Adopt SnakeYAML 2.0; add integration tests for reactive and Nima #6535

Merged
merged 2 commits into from Mar 31, 2023

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Mar 30, 2023

Resolves #6373

Forward-port of PR #5793

See that PR for some discussion.

Because SnakeYAML 2.0 contains backward-incompatible changes to its API, this PR includes two integration tests to make sure users can use the older version of SnakeYAML if they need to, one for reactive (basically the same as the SE test from the 3.x PR) and a new one for Níma.

The PR also repairs a bug introduced in the OpenAPI code when it was ported from SE/reactive to Nima.

Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
@tjquinno tjquinno self-assigned this Mar 30, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 30, 2023
@tjquinno tjquinno linked an issue Mar 30, 2023 that may be closed by this pull request
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno merged commit 1fa6694 into helidon-io:main Mar 31, 2023
12 checks passed
@tjquinno tjquinno deleted the snakeyaml-2.0-4.x-nima branch March 31, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.x] Prepare for SnakeYAML 2.0
2 participants