Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem in AUTO_FLUSH backpressure strategy #6556

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

spericas
Copy link
Member

@spericas spericas commented Apr 4, 2023

Fixed problem in AUTO_FLUSH strategy that may result in pub-sub deadlock. Increment buffer sum before checking watermark and flushing.

…ock. Increment buffer sum before checking watermark and flushing.
@spericas spericas added bug Something isn't working 3.x Issues for 3.x version branch labels Apr 4, 2023
@spericas spericas added this to the 3.2.1 milestone Apr 4, 2023
@spericas spericas self-assigned this Apr 4, 2023
@spericas spericas marked this pull request as draft April 4, 2023 17:53
@spericas spericas added this to Normal priority in Backlog Apr 4, 2023
@spericas spericas marked this pull request as ready for review April 4, 2023 18:03
@spericas spericas requested a review from danielkec April 5, 2023 12:21
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 5, 2023
@spericas spericas requested a review from danielkec April 5, 2023 14:25
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas merged commit 8d3c271 into helidon-io:helidon-3.x Apr 5, 2023
1 check passed
Backlog automation moved this from Normal priority to Closed Apr 5, 2023
danielkec pushed a commit to danielkec/helidon that referenced this pull request Aug 25, 2023
* Fixed problem in AUTO_FLUSH strategy that may result in pub-sub deadlock. Increment buffer sum before checking watermark and flushing.

* Generate large binary file programmatically.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

* Use constant.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

---------

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
romain-grecourt pushed a commit that referenced this pull request Aug 25, 2023
* Fixed problem in AUTO_FLUSH backpressure strategy  (#6556)

* Fixed problem in AUTO_FLUSH strategy that may result in pub-sub deadlock. Increment buffer sum before checking watermark and flushing.

* Generate large binary file programmatically.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

* Use constant.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

---------

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

* Fix intermittent out-of-order chunk #7407 (#7441)

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Co-authored-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>

---------

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Co-authored-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch bug Something isn't working OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Backlog
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants