Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed receive() method to onMessage() in WsListener #6571

Merged
merged 1 commit into from Apr 7, 2023

Conversation

spericas
Copy link
Member

@spericas spericas commented Apr 6, 2023

Renamed receive() method to onMessage() to make it consistent with the other methods in the interface, all of which use "on" as prefix. Part of doc issue #6467.

…e other methods in the interface, all of which use "on" as prefix.
@spericas spericas added websocket WebSocket in Helidon 4.x Version 4.x labels Apr 6, 2023
@spericas spericas added this to the 4.0.0-ALPHA6 milestone Apr 6, 2023
@spericas spericas self-assigned this Apr 6, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 6, 2023
@spericas spericas mentioned this pull request Apr 6, 2023
@spericas spericas added this to Normal priority in Backlog Apr 6, 2023
@spericas spericas moved this from Normal priority to Sprint Scope in Backlog Apr 6, 2023
@spericas spericas requested a review from barchetta April 6, 2023 18:32
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas merged commit a6d4ff0 into helidon-io:main Apr 7, 2023
12 checks passed
Backlog automation moved this from Sprint Scope to Closed Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement. websocket WebSocket in Helidon
Projects
Backlog
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants