Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New document describing the client and server WebSocket APIs in Nima #6578

Merged
merged 2 commits into from Apr 10, 2023

Conversation

spericas
Copy link
Member

@spericas spericas commented Apr 7, 2023

See issue #6467.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas added docs websocket WebSocket in Helidon 4.x Version 4.x labels Apr 7, 2023
@spericas spericas added this to the 4.0.0 milestone Apr 7, 2023
@spericas spericas requested a review from ljamen April 7, 2023 17:38
@spericas spericas self-assigned this Apr 7, 2023
@spericas spericas added this to Backlog in Helidon Doc via automation Apr 7, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 7, 2023
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One comment but its not necessarily something to change. I just wanted to remind myself to follow up with positioning of Nima in the doc.

== API

Helidon Nima provides a WebSocket API that includes support for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a reference and naming perspective, have we decided that the official name is Helidon Nima and not the Helidon Nima WebServer? I'm still a bit confused on how Nima is going to be positioned. I'll follow up and make updates, if needed, in a sep PR.

@spericas spericas merged commit 66a188e into helidon-io:main Apr 10, 2023
12 checks passed
@spericas spericas mentioned this pull request Apr 10, 2023
@ljamen ljamen moved this from Backlog to In progress in Helidon Doc Apr 19, 2023
@ljamen ljamen moved this from In progress to Done in Helidon Doc Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x docs OCA Verified All contributors have signed the Oracle Contributor Agreement. websocket WebSocket in Helidon
Projects
Helidon Doc
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants