Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for different propagators for Jaeger OpenTelemetry integration. #6586

Merged
merged 5 commits into from Apr 13, 2023

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Apr 11, 2023

Resolves #6574

A support for compatibilty with 2.x - we now support Jaeger, B3, and W3C propagators, Jaeger is the default.

Backport issue for 3.x: #6587
There is no need to backport to 2.x, as it is based on OpenTracing

@tomas-langer tomas-langer added tracing 4.x Version 4.x labels Apr 11, 2023
@tomas-langer tomas-langer self-assigned this Apr 11, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 11, 2023
bogedal
bogedal previously approved these changes Apr 12, 2023
Copy link

@bogedal bogedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogedal
Copy link

bogedal commented Apr 13, 2023

Any known timeline for the release of this in version 3.2.1 ?

@tomas-langer tomas-langer merged commit f5bf1ff into helidon-io:main Apr 13, 2023
13 checks passed
@tomas-langer tomas-langer deleted the 6574-jaeger-propagation branch April 13, 2023 10:41
tomas-langer added a commit to tomas-langer/helidon that referenced this pull request Apr 13, 2023
…n. (helidon-io#6586)

* Support for different propagators for Jaeger OpenTelemetry integration.
* Added tests to validate the correct propagators are added

(cherry picked from commit f5bf1ff)
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer added a commit that referenced this pull request Apr 17, 2023
…n. (#6586) (#6611)

* Support for different propagators for Jaeger OpenTelemetry integration.
* Added tests to validate the correct propagators are added

(cherry picked from commit f5bf1ff)
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement. tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants