GeneratedConfigBean should be easily available from Config-driven-services #6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
trentjeff
commented
Apr 24, 2023
| */ | ||
| void __instanceId(String val); |
There was a problem hiding this comment.
note: The setter was taken out of this interface and pushed down to the abstract impl.
trentjeff
commented
Apr 24, 2023
| @@ -67,6 +67,10 @@ static void internalMetaAttributes(StringBuilder builder) { | |||
| builder.append("\tpublic static Map<String, Map<String, Object>> __metaAttributes() {\n" | |||
| + "\t\treturn ").append(BodyContext.TAG_META_PROPS).append(";\n" | |||
There was a problem hiding this comment.
Note: unfortunately we still need the static approach for other use cases.
tomas-langer
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-req to issue #6674