Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] - Clean MP Telemetry dependencies #6815

Merged
merged 3 commits into from May 12, 2023
Merged

[4.x] - Clean MP Telemetry dependencies #6815

merged 3 commits into from May 12, 2023

Conversation

dalexandrov
Copy link
Contributor

Resolves #6811

@dalexandrov dalexandrov added 4.x Version 4.x telemetry labels May 12, 2023
@dalexandrov dalexandrov self-assigned this May 12, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 12, 2023
barchetta
barchetta reviewed May 12, 2023
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can clean up a couple more things in dependencies/pom.xml:

  1. The version.lib.opentelemetry property appears twice
  2. The version.lib.opentelemetry-sdk-extension-autoconfigure property appears twice
  3. You can remove opentelemetry-context, opentelemetry-sdk because those are managed by opentelemetry-bom

@dalexandrov
Copy link
Contributor Author

Done!))

barchetta
barchetta approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dalexandrov dalexandrov merged commit 870fed6 into helidon-io:main May 12, 2023
12 checks passed
@dalexandrov dalexandrov deleted the 6811_MPTelemetry_Remove_deps branch May 12, 2023 17:39
dalexandrov added a commit to dalexandrov/helidon that referenced this pull request May 15, 2023
@dalexandrov
[4.x] - Clean MP Telemetry dependencies (helidon-io#6815)
584b32d 
* Clean dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

Assignees

@dalexandrov dalexandrov

Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement. telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dalexandrov @barchetta