Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] - Remove Microprofile dependencies from SE Telemetry #6998

Merged
merged 2 commits into from Jun 20, 2023
Merged

[4.x] - Remove Microprofile dependencies from SE Telemetry #6998

merged 2 commits into from Jun 20, 2023

Conversation

dalexandrov
Copy link
Contributor

Resolves #6996

@dalexandrov dalexandrov self-assigned this Jun 14, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 14, 2023
tomas-langer
tomas-langer requested changes Jun 15, 2023
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should still be a test in tracing/opentelemetry to make sure it works in Helidon SE, as it is part of the features of the module. It should just use @ServerTest and Helidon Níma instead of MP.

@dalexandrov
Copy link
Contributor Author

Actually no need to run the server. We need only the config module.

@dalexandrov dalexandrov merged commit c181cca into helidon-io:main Jun 20, 2023
12 checks passed
@dalexandrov dalexandrov deleted the 6996_remove_microprofile_from_se_telemetry branch June 20, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@dalexandrov dalexandrov

Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement. telemetry testing tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dalexandrov @tomas-langer