Initial implementation of Helidon connector for Jakarta REST client #7039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
jersey/connector/src/main/java/io/helidon/jersey/connector/HelidonConnector.java
Show resolved
Hide resolved
spericas
force-pushed
the
issue-6739
branch
5 times, most recently
from
a2c11bd
to
f893419
Compare
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…e to incompatibilities. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
...ps/bookstore/bookstore-se/src/test/java/io/helidon/tests/apps/bookstore/se/Http2SslTest.java
Outdated
Show resolved
Hide resolved
tests/integration/oidc/src/test/java/io/helidon/tests/integration/oidc/CookieBasedLoginIT.java
Outdated
Show resolved
Hide resolved
tests/integration/oidc/src/test/java/io/helidon/tests/integration/oidc/QueryBasedLoginIT.java
Outdated
Show resolved
Hide resolved
...integration/oidc/src/test/java/io/helidon/tests/integration/oidc/TenantIdentificationIT.java
Outdated
Show resolved
Hide resolved
romain-grecourt
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One objective of new implementation is to drop dependency on old WebClient and reactive modules. The new connector is not feature complete and currently only support HTTP/1.1. A follow-up issue will be created to track missing features.
In addition to updating all the mock-based unit tests, there is now an integration test for the connector.
This PR includes the following changes tracked by other PRs:
io.helidon.tests.apps.bookstore.se.Http2SslTest. This PR fixes this test to only use HTTP2 when requested and to better log HTTP interactions. Tracked by HTTP/2 test intermittent failure #7097.io.helidon.tests.integration.oidcIT tests. Tracked by 4.x: Helidon Jersey Connector missing features #7094.Fixes #6739