Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve pico integration docs for oci sdk #7040

Merged
merged 4 commits into from Jun 23, 2023
Merged

improve pico integration docs for oci sdk #7040

merged 4 commits into from Jun 23, 2023

Conversation

trentjeff
Copy link
Member

This is a follow-up to some of the comments @ljnelson provided on #6982

@trentjeff trentjeff added the 4.x Version 4.x label Jun 21, 2023
@trentjeff trentjeff added this to the 4.0.0-M1 milestone Jun 21, 2023
@trentjeff trentjeff self-assigned this Jun 21, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 21, 2023
@trentjeff trentjeff marked this pull request as ready for review June 21, 2023 18:59
@trentjeff trentjeff mentioned this pull request Jun 21, 2023
Closed
@trentjeff
Copy link
Member Author

@romain-grecourt @tomas-langer @m0mus - i happened to notice #6969. Seems like our nima integration examples should also be updated to include pico and injection - thoughts on this?

ljnelson
ljnelson previously approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left further suggestions but clicked the big approve button in case you need to get this in as-is.

integrations/oci/sdk/README.md Show resolved Hide resolved
integrations/oci/sdk/README.md Show resolved Hide resolved
integrations/oci/sdk/README.md Outdated Show resolved Hide resolved
integrations/oci/sdk/README.md Show resolved Hide resolved
...ons/oci/sdk/runtime/src/main/java/io/helidon/integrations/oci/sdk/runtime/OciConfigBean.java Outdated Show resolved Hide resolved
...ons/oci/sdk/runtime/src/main/java/io/helidon/integrations/oci/sdk/runtime/OciConfigBean.java Outdated Show resolved Hide resolved
@tomas-langer
Copy link
Member

This will be in conflict with #7008, please do not merge until that PR is merged. Thanks

@trentjeff trentjeff requested a review from ljnelson June 22, 2023 17:17
@m0mus
Copy link
Contributor

m0mus commented Jun 23, 2023

This document covers OCI integration with SE. You should mention it only once and not include information about CDI modules.

@m0mus
Copy link
Contributor

m0mus commented Jun 23, 2023

We have not agreed on naming. You will need to fix it later. I am suggesting filing a follow-up issue.

@m0mus
Copy link
Contributor

m0mus commented Jun 23, 2023

Fix (remove) indent in snippets.

@m0mus
Copy link
Contributor

m0mus commented Jun 23, 2023

It makes sense to indicate exactly the place of snippets in the pom file. Something like: adds the following code under build\pluginManagement\plugin or similar.

@m0mus
Copy link
Contributor

m0mus commented Jun 23, 2023

It would be good to know what modules you can inject and the names of the classes. I expect questions like: I would like to use a component XXX, how can I inject it? Documentation should answer it.

@trentjeff trentjeff mentioned this pull request Jun 23, 2023
Closed
@trentjeff
Copy link
Member Author

Filed follow-up using #7076

@trentjeff trentjeff merged commit 8edd50f into helidon-io:main Jun 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

@ljnelson ljnelson Awaiting requested review from ljnelson

Assignees

@trentjeff trentjeff

Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
4.0.0-M1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trentjeff @tomas-langer @m0mus @ljnelson