3.x: upgrade okio to 3.4.0 #7238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barchetta
added
dependencies
oracle-contributor-agreement
bot
added
the
OCA Verified
romain-grecourt
approved these changes
Jul 26, 2023
This was referenced Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of okio has issues with Java modules (for example see square/okio#1306). This version of okio is written in Kotlin and splits the original
okioartifact intookio(platform agnostic stuff) andokio-jvm(Java classes). We don't needokioat runtime (onlyokio-jvm), and it was causing modularity problems. To work-around this:okiofrom the runtime environment (libsfolder).helidon-tracing-jaegeraddrequires kotlin.stdlib;so thatkotlin-stdlibis included in the module graph. We need this becausekotlin-stdlibis a well-formed Java module, butokio-jvm(which depends on it) is not, and therefore we need some module to depend onkotlin.stdlibfor it to be included in the module graph.Okio is a transative dependency of okhttp which is a transitive dependency of a couple third parties (opentelemetry-exporter-jaeger for example). okhttp is not a direct third party dependency of Helidon -- except for one or two test dependencies.