Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabled test after integration with latest Jersey #7313

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

spericas
Copy link
Member

@spericas spericas commented Aug 4, 2023

Re-enabled test after integration with latest Jersey. Some changes to the example given that Jersey RestClient does appear to provide request scope support with async (there is no propagation). This was used by the test to get the dynamic port in which the server runs. New code uses the Helidon context for that. Test no longer blocks when using Asynchronous in a RestClient interface. See issue #6696.

@spericas spericas added bug Something isn't working 3.x Issues for 3.x version branch testing labels Aug 4, 2023
@spericas spericas added this to the 3.2.3 milestone Aug 4, 2023
@spericas spericas requested a review from barchetta August 4, 2023 14:25
@spericas spericas self-assigned this Aug 4, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 4, 2023
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

… the example given that Jersey RestClient does appear to provide request scope support with async (there is no propagation). This was used by the test to get the dynamic port in which the server runs. New code uses the Helidon context for that. Test no longer blocks when using `Asynchronous` in a RestClient interface.
@spericas spericas merged commit c86339a into helidon-io:helidon-3.x Aug 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch bug Something isn't working OCA Verified All contributors have signed the Oracle Contributor Agreement. testing
Projects
Backlog
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants