New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x Make OciMetricsDataTest.beforeEach public #7333

Merged

romain-grecourt merged 1 commit into helidon-io:main from Captain1653:4-x-private-before-each

Aug 14, 2023

Contributor

Captain1653 commented Aug 8, 2023

Backport 4.x - #7328

oracle-contributor-agreement bot added the OCA Verified label

Member

tomas-langer commented Aug 8, 2023

We have a common practice to declare all JUnit test classes as package local, and their methods as well.


          4.x Make OciMetricsDataTest.beforeEach public

218da97

Captain1653 force-pushed the 4-x-private-before-each branch from 9f845ab to 218da97 Compare

August 8, 2023 16:10

romain-grecourt approved these changes

View reviewed changes

romain-grecourt merged commit e65fef5 into helidon-io:main

12 checks passed

Captain1653 deleted the 4-x-private-before-each branch

August 15, 2023 05:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment