Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x Replace try/catch in tests on assertThrows #7344

Merged
merged 1 commit into from
Sep 12, 2023
Merged

3.x Replace try/catch in tests on assertThrows #7344

merged 1 commit into from
Sep 12, 2023

Conversation

Captain1653
Copy link
Contributor

There are many cases in tests:

try {
  someMethod();
  Assertions.fail("Should be exception");
} catch (SomeException e) {}

I think, it's better to use assertThrows

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 9, 2023
@Captain1653 Captain1653 changed the title Replace try/catch in tests on assertThrows 3.x Replace try/catch in tests on assertThrows Aug 9, 2023
@Captain1653 Captain1653 mentioned this pull request Aug 15, 2023
Merged
1 task
@romain-grecourt romain-grecourt merged commit a3feb95 into helidon-io:helidon-3.x Sep 12, 2023
12 checks passed
@Captain1653 Captain1653 deleted the 3-x-replace-try-catch-assert-throws branch September 13, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Captain1653 @romain-grecourt