Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archetype: Feature parity with 3.x + renaming from nima to se #7409

Merged
merged 16 commits into from
Aug 24, 2023

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Aug 21, 2023

fix #7268 and #7243

@tvallin tvallin added archetypes 4.x Version 4.x labels Aug 21, 2023
@tvallin tvallin self-assigned this Aug 21, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 21, 2023
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to generate a Quickstart SE project (SE -> quickstart). I get an error:

 error: Invocation error: Unresolved variable: db

Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Custom SE and adding Health support and built-in checks, the README says to do: curl -X GET http://localhost:PORT/health/

  • I had to use the URL http://localhost:8080/observe/health
  • Health in SE now returns no content (204), in 3.x it returned content and a 200. If this is indeed how health in SE is to work, the README should mention that (because it feels like a bug when you run curl and nothing appears to happen)

Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed with SE quickstart:

  • READMEs should say "JDK21" not "JDK20"
  • README: "Exercise the application" has curl -X GET http://localhost:8080/simple-greet example shown twice
  • README: Line 113 and 148 consists of 32 blank spaces

Observed with database-se

  • It is configured with tracing (not so in 3.x) and zipkin2.reporter throws an exception at startup
  • curl -X GET http://localhost:8080/pokemon returns "Endpoint not found"

Observed with database-mp using Hibernate

  • Compile warning: [WARNING] unknown enum constant org.osgi.annotation.bundle.Requirement.Resolution.OPTIONAL
  • Compile error:
[ERROR] Failed to execute goal org.hibernate.orm.tooling:hibernate-enhance-maven-plugin:6.1.7.Final:enhance (default) on project database-mp: Unable to enhance class: ObjectFactory.class: Failed to enhance class io.helidon.archetypes.tests.jaxb.ObjectFactory: Java 21 (65) is not supported by the current version of Byte Buddy which officially supports Java 20 (64) - update Byte Buddy or set net.bytebuddy.experimental as a VM property -> [Help 1]

Observed with database-mp using EclipseLink:

  • Same compile warning as with Hibernate
  • Endpoints work!

@barchetta barchetta added this to the 4.0.0-M2 milestone Aug 23, 2023
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough to merge. I've created a followup issue: #7446

@barchetta barchetta merged commit 98c8250 into helidon-io:main Aug 24, 2023
12 checks passed
@tvallin tvallin deleted the archetype-parity branch August 25, 2023 07:52
dalexandrov pushed a commit to dalexandrov/helidon that referenced this pull request Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x archetypes OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants