Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x - Refactor TODO app example to remove the of use NodeJS/NPM #7455

Merged

Conversation

romain-grecourt
Copy link
Contributor

  • Refactor UI to use JQuery + MustacheJS + Material icons (single .css file & single .js file)
  • Refactor frontend service to use WebClient instead of JAXRS Client
  • Simplify BackendServiceClient
  • Update TodoServiceTest to write the backend mockup using WebServer instead of JAXRS
  • Removed Docker and k8s to simplify the running steps
  • Updated README.md

Fixes #7144

- Refactor UI to use JQuery + MustacheJS + Material icons (single .css file & single .js file)
- Refactor frontend service to use WebClient instead of JAXRS Client
- Simplify BackendServiceClient
- Update TodoServiceTest to write the backend mockup using WebServer instead of JAXRS
- Removed Docker and k8s to simplify the running steps
- Updated README.md

Fixes helidon-io#7144
@romain-grecourt romain-grecourt self-assigned this Aug 25, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 25, 2023
@romain-grecourt
Copy link
Contributor Author

This should be ported to 2.x and also to 4.x (with reactive -> blocking)

@romain-grecourt romain-grecourt changed the title Refactor TODO app examples to remove the of use NodeJS/NPM Refactor TODO app example to remove the of use NodeJS/NPM Aug 25, 2023
@romain-grecourt romain-grecourt changed the title Refactor TODO app example to remove the of use NodeJS/NPM 3.x - Refactor TODO app example to remove the of use NodeJS/NPM Aug 25, 2023
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you please create an issue to "forward-port" to 4.x?

@romain-grecourt romain-grecourt merged commit 88a6d33 into helidon-io:helidon-3.x Aug 25, 2023
12 checks passed
@romain-grecourt romain-grecourt deleted the todo-app-example-update branch August 25, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.x] Remove example(s) that depend on node.js
2 participants