4.x: Introduces OciSecretsMpMetaConfigProvider, which adapts OciSecretsConfigSourceProvider to the MpMetaConfigProvider contract #7520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
ljnelson
commented
Sep 6, 2023
| @@ -805,7 +805,12 @@ | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.helidon.integrations.oci</groupId> | |||
| <artifactId>helidon-integrations-oci-secrets-configsource</artifactId> | |||
| <artifactId>helidon-integrations-oci-secrets-config-source</artifactId> | |||
There was a problem hiding this comment.
(Fixes an issue that didn't get caught from the last PR in this area.)
|
Addresses #4238 |
…figSourceProvider to the MpMetaConfigProvider contract. Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
…ce received Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
ljnelson
force-pushed
the
4.x-oci-secrets-mp-config-source-guess-0
branch
from
1fb3af8
to
4500c0e
Compare
ljnelson
changed the title
This was referenced Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR guesses somewhat blindly at how to adapt the existing
OciSecretsConfigSourceProviderto theMpMetaConfigProvidercontract, prioritizing maximum code and meta-configuration reuse. I don't know if it is the correct recipe or not; this is just a guess (that works). Depending on how wrong I guess, I will either close this PR once I get the proper recipe and open a new one, or amend this PR to fix any flaws.Documentation impact: none yet
Update: following guidance, the recipe now:
MpMetaConfigProvider(namedOciSecretsMpMetaConfigProvider) that:OciSecretsConfigSourceProviderthatConfigSourceConfigconsisting of the HelidonConfigSourceso created andMpConfigSources#create(Config)to create aListof MicroProfile ConfigConfigSources from the resulting HelidonConfig