Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: MP testing refactoring #7548

Merged
merged 2 commits into from Sep 18, 2023
Merged

4.x: MP testing refactoring #7548

merged 2 commits into from Sep 18, 2023

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Sep 7, 2023 •
edited

Description

Resolves #7534

  1. Move user modules to testing to align with all other modules in Helidon (where we use testing for types to support users during testing of Helidon applications, and tests to contain our own tests
  2. Refactor group ids (and some artifact ids) to align with what we should have in Helidon in MP tests
  3. Rename restfull to restful, as that is the correct name of the specification

Documentation

There is no change in the types except for being moved to different modules/packages.
The testng dependency is now in provided scope, so if a user wants to test an application using our testng extension, they need to add the following dependency (of correct version) as well (we do not want to enforce a version on our users):

<dependency>
    <groupId>org.testng</groupId>
    <artifactId>testng</artifactId>
    <scope>test</scope>
</dependency>

Two modules are now moved:
GroupId has changed from io.helidon.microprofile.tests to io.helidon.microprofile.testing for JUnit5 and TestNG support for MicroProfile

Junit5:

  1. artifactId has changed from helidon-microprofile-tests-junit5 to helidon-microprofile-testing-junit5
  2. package has changed from io.helidon.microprofile.tests.junit5 to io.helidon.microprofile.testing.junit5
  3. module anme has changed from io.helidon.microprofile.tests.junit5 to io.helidon.microprofile.testing.junit5

TestNG:

  1. artifactId has changed from helidon-microprofile-tests-testng to helidon-microprofile-testing-testng
  2. package has changed from io.helidon.microprofile.tests.testng to io.helidon.microprofile.testing.testng
  3. module anme has changed from io.helidon.microprofile.tests.testng to io.helidon.microprofile.testing.testng

@tomas-langer tomas-langer self-assigned this Sep 7, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 7, 2023
@tomas-langer tomas-langer linked an issue Sep 7, 2023 that may be closed by this pull request
4.x: align tests/testing module in MP #7534
Closed
@tomas-langer tomas-langer added this to the 4.0.0-RC1 milestone Sep 13, 2023
danielkec
danielkec reviewed Sep 14, 2023
View reviewed changes
...oprofile/testing/junit5/src/main/java/io/helidon/microprofile/testing/junit5/AddConfigs.java
@@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.helidon.microprofile.tests.testng;
package io.helidon.microprofile.testing.junit5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why move testng ones to junit and vice-versa?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not. I refactored it using IDE by moving the correct ones around

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used git mv to move the files, yet still some of them appear to be incorrectly marked. I would prefer not to manually change the git patch, so I have no choice but to leave it as is

danielkec
danielkec reviewed Sep 14, 2023
View reviewed changes
...oprofile/testing/testng/src/main/java/io/helidon/microprofile/testing/testng/AddConfigs.java
@@ -13,16 +13,16 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.helidon.microprofile.tests.junit5;
package io.helidon.microprofile.testing.testng;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vice-versa...

@danielkec danielkec self-requested a review September 15, 2023 10:29
danielkec
danielkec previously approved these changes Sep 15, 2023
View reviewed changes
Verdent
Verdent previously approved these changes Sep 15, 2023
View reviewed changes
@tomas-langer
Move MP testing support to testing module
cf42d13 
Align MP tests modules groupIds with guidelines
Resolve review comments
@tomas-langer tomas-langer dismissed stale reviews from Verdent and danielkec via cf42d13 September 15, 2023 11:37
@tomas-langer tomas-langer merged commit ef9eba3 into helidon-io:main Sep 18, 2023
12 checks passed
@tomas-langer tomas-langer deleted the 7534-mp-testing branch September 18, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkec danielkec danielkec approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

@jbescos jbescos Awaiting requested review from jbescos

@spericas spericas Awaiting requested review from spericas

@barchetta barchetta Awaiting requested review from barchetta

@dalexandrov dalexandrov Awaiting requested review from dalexandrov

@Verdent Verdent Awaiting requested review from Verdent

Assignees

@tomas-langer tomas-langer

Labels
4.x Version 4.x microprofile MP OCA Verified All contributors have signed the Oracle Contributor Agreement. testing
Projects
None yet
Milestone
4.0.0-RC1
Development

Successfully merging this pull request may close these issues.

4.x: align tests/testing module in MP
4 participants
@tomas-langer @danielkec @dalexandrov @Verdent