4.x: metrics and openapi endpoints should be authorized by default #7572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvallin
added
enhancement
oracle-contributor-agreement
bot
added
the
OCA Verified
tvallin
changed the title
tvallin
force-pushed
the
metric-openapi-authorized
branch
from
a0b0485
to
0265f44
Compare
tvallin
force-pushed
the
metric-openapi-authorized
branch
from
bcc9a40
to
34e6a49
Compare
tomas-langer
previously requested changes
Sep 21, 2023
...ervice-common/src/test/java/io/helidon/webserver/servicecommon/HelidonSecureFeatureTest.java
Outdated
Show resolved
Hide resolved
...ics/src/test/java/io/helidon/webserver/tests/observe/metrics/ObserveMetricsSecurityTest.java
Outdated
Show resolved
Hide resolved
...ics/src/test/java/io/helidon/webserver/tests/observe/metrics/ObserveMetricsSecurityTest.java
Outdated
Show resolved
Hide resolved
...ics/src/test/java/io/helidon/webserver/tests/observe/metrics/ObserveMetricsSecurityTest.java
Outdated
Show resolved
Hide resolved
...ics/src/test/java/io/helidon/webserver/tests/observe/metrics/ObserveMetricsSecurityTest.java
Outdated
Show resolved
Hide resolved
tvallin
force-pushed
the
metric-openapi-authorized
branch
from
12700ea
to
741c5e0
Compare
romain-grecourt
dismissed
tomas-langer’s stale review
Changes have been made
tvallin
force-pushed
the
metric-openapi-authorized
branch
from
afebe02
to
edfcfec
Compare
romain-grecourt
previously approved these changes
Sep 27, 2023
Signed-off-by: tvallin <thibault.vallin@oracle.com>
romain-grecourt
force-pushed
the
metric-openapi-authorized
branch
from
edfcfec
to
aab69ec
Compare
romain-grecourt
previously approved these changes
Sep 27, 2023
|
Include a fix to #7510 |
Signed-off-by: tvallin <thibault.vallin@oracle.com>
romain-grecourt
approved these changes
Sep 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #7439
Documentation
no impact