4.x: Upgrade jboss logging to 3.5.3.Final

[barchetta]

Description

Upgrades jboss logging to 3.5.3

Had to add requires org.jboss.logging; because it is now a well formed module and must be in module graph.

Documentation

No impact

[barchetta]

Test failures due to module changes. Jboss-logging now has a module-info:

Compiled from "module-info.yml"
module org.jboss.logging@3.5.3.Final {
  requires java.base;
  requires static java.logging;
  requires static log4j.api;
  requires static org.apache.logging.log4j;
  requires static org.slf4j;
  exports org.jboss.logging;
  uses org.jboss.logging.LoggerProvider;
}

Error can be reproduced running the bookstore app using module-path:

java -Dserver.port=30005 --module-path /Users/jdipol/GitHub/barchetta/helidon/tests/apps/bookstore/bookstore-mp/target/bookstore-mp.jar:/Users/jdipol/GitHub/barchetta/helidon/tests/apps/bookstore/bookstore-mp/target/libs -m io.helidon.tests.apps.bookstore.mp/io.helidon.tests.apps.bookstore.mp.Main
2023.09.15 16:16:36 INFO io.helidon.logging.jul.JulProvider Thread[#1,main,5,main]: Logging at initialization configured using context classpath: /logging.properties
Exception in thread "main" java.lang.NoClassDefFoundError: org/jboss/logging/BasicLogger
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1105)
	at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:182)
	at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:821)
	at java.base/jdk.internal.loader.BuiltinClassLoader.findClassInModuleOrNull(BuiltinClassLoader.java:741)
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:665)
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1105)
	at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:182)
	at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:821)
	at java.base/jdk.internal.loader.BuiltinClassLoader.findClassInModuleOrNull(BuiltinClassLoader.java:741)
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:665)
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	at weld.core.impl@4.0.0-SNAPSHOT/org.jboss.weld.bootstrap.WeldStartup.<clinit>(WeldStartup.java:150)
	at weld.core.impl@4.0.0-SNAPSHOT/org.jboss.weld.bootstrap.WeldBootstrap.<init>(WeldBootstrap.java:57)
	at io.helidon.microprofile.cdi@4.0.0-SNAPSHOT/io.helidon.microprofile.cdi.HelidonContainerImpl.<init>(HelidonContainerImpl.java:121)
	at io.helidon.microprofile.cdi@4.0.0-SNAPSHOT/io.helidon.microprofile.cdi.HelidonContainerImpl.create(HelidonContainerImpl.java:131)
	at io.helidon.microprofile.cdi@4.0.0-SNAPSHOT/io.helidon.microprofile.cdi.BuildTimeInitializer.lambda$createContainer$2(BuildTimeInitializer.java:63)
	at io.helidon.microprofile.cdi@4.0.0-SNAPSHOT/io.helidon.microprofile.cdi.BuildTimeInitializer.accessContainer(BuildTimeInitializer.java:72)
	at io.helidon.microprofile.cdi@4.0.0-SNAPSHOT/io.helidon.microprofile.cdi.BuildTimeInitializer.createContainer(BuildTimeInitializer.java:62)
	at io.helidon.microprofile.cdi@4.0.0-SNAPSHOT/io.helidon.microprofile.cdi.BuildTimeInitializer.<clinit>(BuildTimeInitializer.java:37)
	at io.helidon.microprofile.cdi@4.0.0-SNAPSHOT/io.helidon.microprofile.cdi.ContainerInstanceHolder.fromBuildTimeInitializer(ContainerInstanceHolder.java:65)
	at io.helidon.microprofile.cdi@4.0.0-SNAPSHOT/io.helidon.microprofile.cdi.ContainerInstanceHolder.lambda$get$1(ContainerInstanceHolder.java:56)
	at io.helidon.microprofile.cdi@4.0.0-SNAPSHOT/io.helidon.microprofile.cdi.ContainerInstanceHolder.access(ContainerInstanceHolder.java:91)
	at io.helidon.microprofile.cdi@4.0.0-SNAPSHOT/io.helidon.microprofile.cdi.ContainerInstanceHolder.get(ContainerInstanceHolder.java:53)
	at io.helidon.microprofile.cdi@4.0.0-SNAPSHOT/io.helidon.microprofile.cdi.HelidonContainer.instance(HelidonContainer.java:48)
	at io.helidon.microprofile.server@4.0.0-SNAPSHOT/io.helidon.microprofile.server.Server$Builder.build(Server.java:180)
	at io.helidon.microprofile.server@4.0.0-SNAPSHOT/io.helidon.microprofile.server.Server.create(Server.java:77)
	at io.helidon.tests.apps.bookstore.mp@4.0.0-SNAPSHOT/io.helidon.tests.apps.bookstore.mp.Main.startServer(Main.java:52)
	at io.helidon.tests.apps.bookstore.mp@4.0.0-SNAPSHOT/io.helidon.tests.apps.bookstore.mp.Main.main(Main.java:39)
Caused by: java.lang.ClassNotFoundException: org.jboss.logging.BasicLogger
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	... 37 more

Workaround is to add --add-modules org.jboss.logging. So we probably need to add a requires org.jboss.logging; somewhere