Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] - Fix java.lang.ClassNotFoundException: io.helidon.logging.jul.HelidonConsoleHandler in Examples #7866

Merged
merged 3 commits into from Oct 20, 2023
Merged

[4.x] - Fix java.lang.ClassNotFoundException: io.helidon.logging.jul.HelidonConsoleHandler in Examples #7866

merged 3 commits into from Oct 20, 2023

Conversation

dalexandrov
Copy link
Contributor

Resolves #7865

@dalexandrov
Fix ava.lang.ClassNotFoundException: io.helidon.logging.jul.HelidonCo…
ec7739d 
…nsoleHandler

Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov dalexandrov added bug Something isn't working 4.x Version 4.x labels Oct 20, 2023
@dalexandrov dalexandrov self-assigned this Oct 20, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 20, 2023
@tvallin
Copy link
Member

tvallin commented Oct 20, 2023 •
edited

It looks like there is still the issue with todo-app example.

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running io.helidon.examples.todos.backend.BackendTests
SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#noProviders for further details.
There is no Helidon logging implementation on classpath, skipping log configuration.
Can't load log handler "io.helidon.logging.jul.HelidonConsoleHandler"
java.lang.ClassNotFoundException: io.helidon.logging.jul.HelidonConsoleHandler
java.lang.ClassNotFoundException: io.helidon.logging.jul.HelidonConsoleHandler

@dalexandrov
Copy link
Contributor Author

@tvallin hmm, does not show on my machine

@dalexandrov
Add log handler to tests
760b18c 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@tvallin
Copy link
Member

tvallin commented Oct 20, 2023 •
edited

@dalexandrov , is your machine running on MacOS ?

The BackendTests are enabled only for Linux, so it won't show up on your machine. The log I posted is coming from the pipeline.

@dalexandrov
Copy link
Contributor Author

@tvallin got it! Thanks! Fixed!

@dalexandrov
Add log handler for todo backend test
50fb869 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
barchetta
barchetta approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@barchetta barchetta merged commit adf212c into helidon-io:main Oct 20, 2023
12 checks passed
@dalexandrov dalexandrov deleted the fix-console-handler branch October 20, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

Assignees

@dalexandrov dalexandrov

Labels
4.x Version 4.x bug Something isn't working OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dalexandrov @tvallin @barchetta