Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify SE metrics config examples #7875

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Simplify SE metrics config examples #7875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 8 additions & 16 deletions docs/includes/guides/metrics.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,18 +201,14 @@ ifdef::se-flavor[]
[source,yaml]
.Configuration properties file disabling metrics
----
server:
features:
observe:
observers:
metrics:
enabled: false
metrics:
enabled: false
----
endif::se-flavor[]
// end::disabling-whole-intro[]

// tag::disabling-whole-summary[]
With metrics processing disabled, Helidon never updates any {metrics} and the `{metrics-endpoint}` endpoints respond with `404`.
With metrics processing disabled, Helidon never updates any {metrics} and the `{metrics-endpoint}` endpoint responds with `404` and a message indicating metrics are disabled.
// end::disabling-whole-summary[]
// end::disabling-whole[]

Expand Down Expand Up @@ -357,15 +353,11 @@ endif::mp-flavor[]
ifdef::se-flavor[]
[source,yaml]
----
server:
features:
observe:
observers:
metrics:
key-performance-indicators:
extended: true
long-running:
threshold-ms: 2000
metrics:
key-performance-indicators:
extended: true
long-running:
threshold-ms: 2000
----
endif::se-flavor[]
// end::KPI[]
Expand Down
24 changes: 8 additions & 16 deletions docs/includes/metrics/metrics-config.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,11 @@ endif::[]
ifdef::se-flavor[]
[source,yaml]
----
server:
features:
observe:
observers:
metrics:
enabled: false
metrics:
enabled: false
----
endif::[]
Helidon does not update metrics, and the `{metrics-endpoint}` endpoints respond with `404`..
Helidon does not update metrics, and the `{metrics-endpoint}` endpoint responds with `404` and a message indicating metrics are disabled.

[#config-kpi]
==== Collecting Basic and Extended Key Performance Indicator (KPI) {metrics_uc}
Expand All @@ -95,15 +91,11 @@ endif::[]
ifdef::se-flavor[]
[source,yaml]
----
server:
features:
observe:
observers:
metrics:
key-performance-indicators:
extended: true
long-running:
threshold-ms: 2000
metrics:
key-performance-indicators:
extended: true
long-running:
threshold-ms: 2000
----
endif::[]

Expand Down