Fix premature access to RegistryFactory #8118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
changed the title
ljnelson
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8117
The Helidon MP metrics
RegistryFactorylogged the warning because the JPA CDI extension was running some start-up complete code before the metrics CDI extension had a chance to prepare Helidon MP metrics.The fix sets the priority on the JPA extension observer to be later than the corresponding priority on the metrics extension observer.
Not as part of the PR I temporarily changed the
RegistryFactorycode to thrown an exception instead of logging a warning, and the pipelines passed so it seems that no other CDI extensions need a similar adjustment.