Cleans up and simplifies logic to determine which type of IP addresses to consider #8280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
…s (v4 or v6) to consider during name resolution. No longer inspect hosts interfaces to determine priority. Honors JVM properties defined for this purpose. Also updates TcpClientConnection to use whatever strategy specified by a user as part of a WebClient's configuration.
spericas
force-pushed
the
issue-8205
branch
3 times, most recently
from
bc7946a
to
0e99d51
Compare
…nnection. New tests for DefaultDnsResolver.
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Verdent
requested changes
Jan 23, 2024
webclient/api/src/main/java/io/helidon/webclient/api/DefaultAddressLookupFinder.java
Outdated
Show resolved
Hide resolved
webclient/api/src/main/java/io/helidon/webclient/api/DefaultAddressLookupFinder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Verdent
approved these changes
Jan 24, 2024
This was referenced Jan 24, 2024
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Feb 23, 2024
…s to consider (helidon-io#8280) * Cleans up and simplifies logic to determine which type of IP addresses (v4 or v6) to consider during name resolution. No longer inspect hosts interfaces to determine priority. Honors JVM properties defined for this purpose. Also updates TcpClientConnection to use whatever strategy specified by a user as part of a WebClient's configuration. * Moves logic of name resolution to DefaultDnsResolver from TcpClientConnection. New tests for DefaultDnsResolver. * Modified test to use default DnsAddresslookup. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Guard logging calls and deprecate useDefaultJavaResolver() method. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> --------- Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tvallin
pushed a commit
to tvallin/helidon
that referenced
this pull request
Feb 28, 2024
…s to consider (helidon-io#8280) * Cleans up and simplifies logic to determine which type of IP addresses (v4 or v6) to consider during name resolution. No longer inspect hosts interfaces to determine priority. Honors JVM properties defined for this purpose. Also updates TcpClientConnection to use whatever strategy specified by a user as part of a WebClient's configuration. * Moves logic of name resolution to DefaultDnsResolver from TcpClientConnection. New tests for DefaultDnsResolver. * Modified test to use default DnsAddresslookup. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Guard logging calls and deprecate useDefaultJavaResolver() method. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> --------- Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up and simplifies logic to determine which type of IP addresses (v4 or v6) to consider during name resolution. No longer inspect hosts interfaces to determine priority. Honors JVM properties defined for this purpose. Also updates TcpClientConnection to use whatever strategy specified by a user as part of a WebClient's configuration.
Documentation
Needs doc update