Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Archetype - Add jpms option with false as default #8310

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Jan 30, 2024

Description

fix #8308

Documentation

no impact

Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin added 3.x Issues for 3.x version branch archetypes labels Jan 30, 2024
@tvallin tvallin self-assigned this Jan 30, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 30, 2024
@tvallin tvallin marked this pull request as draft January 30, 2024 10:31
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the main class ?

Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin marked this pull request as ready for review January 31, 2024 13:34
@tvallin tvallin merged commit 6996630 into helidon-io:helidon-3.x Feb 1, 2024
12 checks passed
@tvallin tvallin deleted the 3.x-archetype-jpms branch February 1, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch archetypes OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants