[4.x] Improve examples test coverage #8338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tvallin <thibault.vallin@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
There was a problem hiding this comment.
The only description is "Improve examples test coverage" in both the referenced issue and this PR.
Can you please:
- Update the issue and describe the problem that needs to be solved (E.g. foo and bar examples are broken because the unit tests aren't exercising critical parts ; we need to add integration tests to ensure that the examples are working.)
- Update this PR description to describe the changes (E.g. add integration test for mysql and oracle db using test containers)
Signed-off-by: tvallin <thibault.vallin@oracle.com>
romain-grecourt
approved these changes
Feb 14, 2024
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Feb 23, 2024
* Container test Signed-off-by: tvallin <thibault.vallin@oracle.com> * refactor tests Signed-off-by: tvallin <thibault.vallin@oracle.com> --------- Signed-off-by: tvallin <thibault.vallin@oracle.com>
tvallin
added a commit
to tvallin/helidon
that referenced
this pull request
Feb 28, 2024
* Container test Signed-off-by: tvallin <thibault.vallin@oracle.com> * refactor tests Signed-off-by: tvallin <thibault.vallin@oracle.com> --------- Signed-off-by: tvallin <thibault.vallin@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #8337
Introduce integration test using test containers :
Documentation
no impact