Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: Releasing entity count down latch even if connection is set to close. #8376

Merged
merged 1 commit into from
Feb 14, 2024
Merged

4.x: Releasing entity count down latch even if connection is set to close. #8376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions webserver/webserver/src/main/java/io/helidon/webserver/http1/Http1Connection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ private void route(HttpPrologue prologue, WritableHeaders<?> headers) {

routing.route(ctx, request, response);

consumeEntity(request, response);
consumeEntity(request, response, entityReadLatch);
try {
entityReadLatch.await();
} catch (InterruptedException e) {
Expand All @@ -433,9 +433,10 @@ private void route(HttpPrologue prologue, WritableHeaders<?> headers) {
}
}

private void consumeEntity(Http1ServerRequest request, Http1ServerResponse response) {
private void consumeEntity(Http1ServerRequest request, Http1ServerResponse response, CountDownLatch entityReadLatch) {
if (response.headers().contains(HeaderValues.CONNECTION_CLOSE) || request.content().consumed()) {
// we do not care about request entity if connection is getting closed
entityReadLatch.countDown();
return;
}
// consume the entity if not consumed by routing
Expand Down
Loading