Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - Fix WebServer Mutual TLS example #8409

Conversation

romain-grecourt
Copy link
Contributor

Description

Fix configuration add endpoint-identification-algorithm = NONE to the server "secured" socket

Other changes:

  • Update README to make it easier to run and exercise the example
  • Remove client.tls.endpoint-identification-algorithm configuration (not needed)
  • Replace test meta config with config override (to set the ports to '0')
  • Replace deprecated Header.value() with Header.get()

Documentation

None

Fix configuration add endpoint-identification-algorithm = NONE to the server "secured" socket

Other changes:
- Update README to make it easier to run and exercise the example
- Remove client.tls.endpoint-identification-algorithm configuration (not needed)
- Replace test meta config with config override (to set the ports to '0')
- Replace deprecated Header.value() with Header.get()
@romain-grecourt romain-grecourt added bug Something isn't working examples webserver 4.x Version 4.x labels Feb 22, 2024
@romain-grecourt romain-grecourt added this to the 4.0.6 milestone Feb 22, 2024
@romain-grecourt romain-grecourt self-assigned this Feb 22, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 22, 2024
barchetta
barchetta previously approved these changes Feb 22, 2024
@romain-grecourt romain-grecourt merged commit 7d5ec7e into helidon-io:main Feb 23, 2024
12 checks passed
@romain-grecourt romain-grecourt deleted the 4.x-fix-webserver-mutual-tls-example branch February 23, 2024 01:36
Copy link
Contributor

@danielkec danielkec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

hrstoyanov pushed a commit to hrstoyanov/helidon that referenced this pull request Feb 23, 2024
* 4.x - Fix WebServer Mutual TLS example

Fix configuration add endpoint-identification-algorithm = NONE to the server "secured" socket

Other changes:
- Update README to make it easier to run and exercise the example
- Remove client.tls.endpoint-identification-algorithm configuration (not needed)
- Replace test meta config with config override (to set the ports to '0')
- Replace deprecated Header.value() with Header.get()

* Fix test setup

* fix builder setup

* Fix copyright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working examples OCA Verified All contributors have signed the Oracle Contributor Agreement. webserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants