4.x: Introducing a test to validate that combination of config annotations… #8491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and test yaml works in HelidonTest together with FaultTolerance. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
added
fault-tolerance
testing
backport
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
previously approved these changes
Mar 21, 2024
|
I just had a talk with a customer that claims this is not working in 4.x. I need to review their reproducer and see the status. I will either merge this PR, or update it with new test and a fix |
spericas
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and test yaml works in HelidonTest together with FaultTolerance.
And actual fix of the problem - the same way this was fixed in 2.x.
Related to #8478
"forward port" of #8487
###Description
This was a bug in 2.x that is fixed as a side effect of other changes in 3.x. Adding a test to make sure we continue supporting this.